pgsql: git_topo_order script, to match up commits across branches.

Lists: pgsql-committerspgsql-hackers
From: Robert Haas <rhaas(at)postgresql(dot)org>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: git_topo_order script, to match up commits across branches.
Date: 2010-09-21 11:00:24
Message-ID: E1Oy0aG-0008SJ-AH@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers pgsql-hackers

git_topo_order script, to match up commits across branches.

This script is intended to substitute for cvs2cl in generating release
notes and scrutinizing what got back-patched to which branches.

Script by me. Support for --since by Alex Hunsaker.

Branch
------
master

Details
-------
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=1b984d43e54a969da26277d913a41ffd5ccfc1e8

Modified Files
--------------
src/tools/git_topo_order | 155 ++++++++++++++++++++++++++++++++++++++++++++++
1 files changed, 155 insertions(+), 0 deletions(-)


From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: git_topo_order script, to match up commits across branches.
Date: 2010-09-24 19:32:45
Message-ID: 23645.1285356765@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers pgsql-hackers

Robert Haas <rhaas(at)postgresql(dot)org> writes:
> git_topo_order script, to match up commits across branches.
> This script is intended to substitute for cvs2cl in generating release
> notes and scrutinizing what got back-patched to which branches.

BTW ... I don't especially care for the name you picked for this script.
The fact that it does a topological sort is an implementation detail
that its users couldn't care less about, especially since that doesn't
matter except for corner cases. How about "collate_git_log" or
something along that line?

regards, tom lane


From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "pgsql-committers(at)postgresql(dot)org" <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: git_topo_order script, to match up commits across branches.
Date: 2010-09-24 21:34:10
Message-ID: 2F98B6AB-9D32-4743-A586-22739C69FA61@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers pgsql-hackers

On Sep 24, 2010, at 3:32 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <rhaas(at)postgresql(dot)org> writes:
>> git_topo_order script, to match up commits across branches.
>> This script is intended to substitute for cvs2cl in generating release
>> notes and scrutinizing what got back-patched to which branches.
>
> BTW ... I don't especially care for the name you picked for this script.
> The fact that it does a topological sort is an implementation detail
> that its users couldn't care less about, especially since that doesn't
> matter except for corner cases. How about "collate_git_log" or
> something along it.

I don't think that's any better - collate could mean anything - but I don't think it's any worse, either. Change it if you want.

...Robert


From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: "pgsql-committers(at)postgresql(dot)org" <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: git_topo_order script, to match up commits across branches.
Date: 2010-09-24 21:36:59
Message-ID: 28796.1285364219@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers pgsql-hackers

Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Sep 24, 2010, at 3:32 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> BTW ... I don't especially care for the name you picked for this script.
>> The fact that it does a topological sort is an implementation detail
>> that its users couldn't care less about, especially since that doesn't
>> matter except for corner cases. How about "collate_git_log" or
>> something along it.

> I don't think that's any better - collate could mean anything - but I don't think it's any worse, either. Change it if you want.

Well, I definitely think that the name should suggest a connection to
"git log". I agree that "collate" might not be the best possible verb
here --- anyone have a better suggestion?

regards, tom lane


From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-committers(at)postgresql(dot)org" <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: git_topo_order script, to match up commits across branches.
Date: 2010-09-24 22:09:48
Message-ID: 1285364564-sup-5639@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers pgsql-hackers

Excerpts from Tom Lane's message of vie sep 24 17:36:59 -0400 2010:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> > On Sep 24, 2010, at 3:32 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> >> BTW ... I don't especially care for the name you picked for this script.
> >> The fact that it does a topological sort is an implementation detail
> >> that its users couldn't care less about, especially since that doesn't
> >> matter except for corner cases. How about "collate_git_log" or
> >> something along it.
>
> > I don't think that's any better - collate could mean anything - but I don't think it's any worse, either. Change it if you want.
>
> Well, I definitely think that the name should suggest a connection to
> "git log". I agree that "collate" might not be the best possible verb
> here --- anyone have a better suggestion?

How about something content-free like "pg_git_log"?

--
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support


From: Gurjeet Singh <singh(dot)gurjeet(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-committers(at)postgresql(dot)org" <pgsql-committers(at)postgresql(dot)org>, PGSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgsql: git_topo_order script, to match up commits across branches.
Date: 2010-09-24 22:53:01
Message-ID: AANLkTi=B9APBSxiOjQx9w6KQPdVysFHg54-+Un5xVyH7@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers pgsql-hackers

On Fri, Sep 24, 2010 at 6:09 PM, Alvaro Herrera
<alvherre(at)commandprompt(dot)com>wrote:

> Excerpts from Tom Lane's message of vie sep 24 17:36:59 -0400 2010:
> > Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> > > On Sep 24, 2010, at 3:32 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > >> BTW ... I don't especially care for the name you picked for this
> script.
> > >> The fact that it does a topological sort is an implementation detail
> > >> that its users couldn't care less about, especially since that doesn't
> > >> matter except for corner cases. How about "collate_git_log" or
> > >> something along it.
> >
> > > I don't think that's any better - collate could mean anything - but I
> don't think it's any worse, either. Change it if you want.
> >
> > Well, I definitely think that the name should suggest a connection to
> > "git log". I agree that "collate" might not be the best possible verb
> > here --- anyone have a better suggestion?
>
> How about something content-free like "pg_git_log"?
>

If it resembles cvs2cl then why not name it git2cl? Or git_changelog.

Since it doesn't do anything specific to Postgres' git, lets not have any pg
in there.

Regards,
--
gurjeet.singh
@ EnterpriseDB - The Enterprise Postgres Company
http://www.EnterpriseDB.com

singh(dot)gurjeet(at){ gmail | yahoo }.com
Twitter/Skype: singh_gurjeet

Mail sent from my BlackLaptop device


From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Gurjeet Singh <singh(dot)gurjeet(at)gmail(dot)com>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-committers(at)postgresql(dot)org" <pgsql-committers(at)postgresql(dot)org>, PGSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] Re: pgsql: git_topo_order script, to match up commits across branches.
Date: 2010-09-24 23:28:53
Message-ID: 4C9D3435.6030908@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers pgsql-hackers

On 09/24/2010 06:53 PM, Gurjeet Singh wrote:
> If it resembles cvs2cl then why not name it git2cl? Or git_changelog.
>
>

+1 for git_changelog

cheers

andrew


From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Gurjeet Singh <singh(dot)gurjeet(at)gmail(dot)com>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "pgsql-committers(at)postgresql(dot)org" <pgsql-committers(at)postgresql(dot)org>, PGSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgsql: git_topo_order script, to match up commits across branches.
Date: 2010-09-25 02:20:54
Message-ID: AANLkTi=JLnr9ZU+1h5PpjMzovXUcsmkV8eJPOJiY3D2U@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers pgsql-hackers

On Fri, Sep 24, 2010 at 6:53 PM, Gurjeet Singh <singh(dot)gurjeet(at)gmail(dot)com> wrote:
> Since it doesn't do anything specific to Postgres' git, lets not have any pg
> in there.

Assuming you discount the hard-coded list of our active branch heads, of course.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company


From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Gurjeet Singh <singh(dot)gurjeet(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "pgsql-committers(at)postgresql(dot)org" <pgsql-committers(at)postgresql(dot)org>, PGSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgsql: git_topo_order script, to match up commits across branches.
Date: 2010-09-25 03:11:34
Message-ID: 1285384139-sup-8202@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers pgsql-hackers

Excerpts from Robert Haas's message of vie sep 24 22:20:54 -0400 2010:
> On Fri, Sep 24, 2010 at 6:53 PM, Gurjeet Singh <singh(dot)gurjeet(at)gmail(dot)com> wrote:
> > Since it doesn't do anything specific to Postgres' git, lets not have any pg
> > in there.
>
> Assuming you discount the hard-coded list of our active branch heads, of course.

Also, I thought it resembled pgcvslog more than cvs2cl.
+1 to git_changelog anyway.

--
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support


From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Gurjeet Singh <singh(dot)gurjeet(at)gmail(dot)com>, "pgsql-committers(at)postgresql(dot)org" <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: git_topo_order script, to match up commits across branches.
Date: 2010-09-25 23:32:09
Message-ID: 3641.1285457529@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers pgsql-hackers

Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> +1 to git_changelog anyway.

That seems to be the consensus position, so done.

regards, tom lane