| Lists: | pgsql-patches |
|---|
| From: | Alvaro Herrera <alvherre(at)dcc(dot)uchile(dot)cl> |
|---|---|
| To: | Patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Remove traces of xfunc |
| Date: | 2004-04-24 21:58:47 |
| Message-ID: | 20040424215847.GA8333@dcc.uchile.cl |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-patches |
Hackers,
While playing with the init code I noticed traces of Hellerstein's
"expensive function optimization". It is completely disabled, uses
functions nowhere to be defined, and is out of date. So I removed it.
Here is the patch. Note that it takes out the "pruneable" field from
struct RelOptInfo, since it's not used.
Tom Lane has said a couple of times that he thinks this maybe can be
resurrected; but even if it is, most likely it won't use this code
(what code? These are only hooks.)
(To the patcher: the file src/backend/lib/lispsort.c can also be removed
after this change)
--
Alvaro Herrera (<alvherre[a]dcc.uchile.cl>)
"Hoy es el primer día del resto de mi vida"
| Attachment | Content-Type | Size |
|---|---|---|
| xfunc.patch | text/plain | 7.7 KB |
| From: | Neil Conway <neilc(at)samurai(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)dcc(dot)uchile(dot)cl> |
| Cc: | Patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: Remove traces of xfunc |
| Date: | 2004-04-25 04:20:01 |
| Message-ID: | D1F91295-966F-11D8-BDD5-000A95AB279E@samurai.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-patches |
On 24-Apr-04, at 5:58 PM, Alvaro Herrera wrote:
> While playing with the init code I noticed traces of Hellerstein's
> "expensive function optimization". It is completely disabled, uses
> functions nowhere to be defined, and is out of date. So I removed it.
I'll apply this within 24 hours.
-Neil
| From: | Alvaro Herrera <alvherre(at)dcc(dot)uchile(dot)cl> |
|---|---|
| To: | Neil Conway <neilc(at)samurai(dot)com> |
| Cc: | Patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: Remove traces of xfunc |
| Date: | 2004-04-25 04:43:38 |
| Message-ID: | 20040425044338.GB14536@dcc.uchile.cl |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-patches |
On Sun, Apr 25, 2004 at 12:20:01AM -0400, Neil Conway wrote:
> On 24-Apr-04, at 5:58 PM, Alvaro Herrera wrote:
> >While playing with the init code I noticed traces of Hellerstein's
> >"expensive function optimization". It is completely disabled, uses
> >functions nowhere to be defined, and is out of date. So I removed it.
>
> I'll apply this within 24 hours.
Cool. I forgot to mention that the Makefile in src/backend/lib has to
be modified too if you drop the lispsort.c file.
--
Alvaro Herrera (<alvherre[a]dcc.uchile.cl>)
Jajaja! Solo hablaba en serio!
| From: | Neil Conway <neilc(at)samurai(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)dcc(dot)uchile(dot)cl> |
| Cc: | Patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: Remove traces of xfunc |
| Date: | 2004-04-25 18:41:14 |
| Message-ID: | 21A2A586-96E8-11D8-AF9F-000A95AB279E@samurai.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-patches |
On 24-Apr-04, at 5:58 PM, Alvaro Herrera wrote:
> While playing with the init code I noticed traces of Hellerstein's
> "expensive function optimization". It is completely disabled, uses
> functions nowhere to be defined, and is out of date. So I removed it.
Applied -- thanks for the patch!
> (To the patcher: the file src/backend/lib/lispsort.c can also be
> removed
> after this change)
Done, and src/backend/lib/Makefile updated (thanks for the note).
-Neil