| Lists: | pgsql-hackers |
|---|
| From: | Maciek Sakrejda <m(dot)sakrejda(at)gmail(dot)com> |
|---|---|
| To: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | [PATCH] Doc fix for VACUUM FREEZE |
| Date: | 2013-12-18 01:14:32 |
| Message-ID: | CAOtHd0B3qqhUzo_8zMfcQJw-9MS2oh4qvyrvjoKzA=KpkEsrxQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
VACUUM FREEZE sets both vacuum_freeze_min_age and vacuum_freeze_table_age
to 0, but only the former is documented. This patch notes that the other
setting is also affected.
| From: | Maciek Sakrejda <m(dot)sakrejda(at)gmail(dot)com> |
|---|---|
| To: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Doc fix for VACUUM FREEZE |
| Date: | 2013-12-18 01:16:10 |
| Message-ID: | CAOtHd0B0gU8mL_qsmXheDfFHf2czdz3Gv6zN-JxnV0j_pLk4bw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
(now with patch--sorry about that)
| Attachment | Content-Type | Size |
|---|---|---|
| correct-vacuum-freeze-docs.patch | text/x-diff | 722 bytes |
| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Maciek Sakrejda <m(dot)sakrejda(at)gmail(dot)com> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Doc fix for VACUUM FREEZE |
| Date: | 2013-12-20 04:12:31 |
| Message-ID: | CAA4eK1JN8SUBJgiMx3A+n=6z8rGUtHxozocJiCVWrVL1w3+biQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Wed, Dec 18, 2013 at 6:46 AM, Maciek Sakrejda <m(dot)sakrejda(at)gmail(dot)com> wrote:
>VACUUM FREEZE sets both vacuum_freeze_min_age and vacuum_freeze_table_age to 0, but only the former is documented. This patch notes that the other setting is also affected.
> (now with patch--sorry about that)
Your explanation and patch seems fine to me.
Kindly submit your patch in Open CommitFest
(https://commitfest.postgresql.org/action/commitfest_view?id=21).
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | Maciek Sakrejda <m(dot)sakrejda(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Doc fix for VACUUM FREEZE |
| Date: | 2014-01-03 15:32:56 |
| Message-ID: | 52C6D828.7070908@gmx.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On 12/17/13, 8:16 PM, Maciek Sakrejda wrote:
> (now with patch--sorry about that)
This patch doesn't apply.
| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | Maciek Sakrejda <m(dot)sakrejda(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Doc fix for VACUUM FREEZE |
| Date: | 2014-01-14 07:39:07 |
| Message-ID: | CAA4eK1+WJMevusJo4RJxX4533JbD54o-ygEMyH1jRSv2zuDsnA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Fri, Jan 3, 2014 at 9:02 PM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
> On 12/17/13, 8:16 PM, Maciek Sakrejda wrote:
>> (now with patch--sorry about that)
>
> This patch doesn't apply.
There are some recent changes around same place which broke this
patch. Please find the modified patch attached with this mail, I had
changed order of specifying vacuum_freeze_min_age and
vacuum_freeze_table_age in Vacuum FREEZE option.
I will mark this patch as Ready For Committer, unless there is
any other objection for this patch.
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| correct-vacuum-freeze-docs_v2.patch | application/octet-stream | 850 bytes |
| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, Maciek Sakrejda <m(dot)sakrejda(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Doc fix for VACUUM FREEZE |
| Date: | 2014-01-14 19:50:12 |
| Message-ID: | CA+TgmoZiPyGGWdUiXohxx6_T9YeuysU_sP0YHOCE7q_=Tyf8LQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Tue, Jan 14, 2014 at 2:39 AM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> On Fri, Jan 3, 2014 at 9:02 PM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
>> On 12/17/13, 8:16 PM, Maciek Sakrejda wrote:
>>> (now with patch--sorry about that)
>>
>> This patch doesn't apply.
>
> There are some recent changes around same place which broke this
> patch. Please find the modified patch attached with this mail, I had
> changed order of specifying vacuum_freeze_min_age and
> vacuum_freeze_table_age in Vacuum FREEZE option.
>
> I will mark this patch as Ready For Committer, unless there is
> any other objection for this patch.
Committed with a grammatical correction.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company