"CLUSTER VERBOSE" tab completion

Lists: pgsql-hackers
From: Jeff Janes <jeff(dot)janes(at)gmail(dot)com>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: "CLUSTER VERBOSE" tab completion
Date: 2012-08-18 02:18:52
Message-ID: CAMkU=1xsN_V072-df__o=nKuM9PEuSWecwqatyo61N5weJDTgg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

tab completion will add "USING" after CLUSTER VERBOSE, as if VERBOSE
were the name of a table.

Instead of just making it not do the wrong thing, I tried to make it
actually do the right thing.

It doesn't fill in the VERBOSE for you, you have to type that in full,
but then it completes table names afterward (and USING and index names
after that)

Cheers,

Jeff

Attachment Content-Type Size
cluster_verbose_complete_v1.patch application/octet-stream 2.3 KB

From: Jeff Janes <jeff(dot)janes(at)gmail(dot)com>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: "CLUSTER VERBOSE" tab completion
Date: 2012-08-19 20:55:18
Message-ID: CAMkU=1yBFpjnF3zVLLCcse1KAQ_EVeOMKLBN3qpXBJQzwCVaew@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Fri, Aug 17, 2012 at 7:18 PM, Jeff Janes <jeff(dot)janes(at)gmail(dot)com> wrote:
> tab completion will add "USING" after CLUSTER VERBOSE, as if VERBOSE
> were the name of a table.
>
> Instead of just making it not do the wrong thing, I tried to make it
> actually do the right thing.
>
> It doesn't fill in the VERBOSE for you, you have to type that in full,

This short coming has now been rectified.

Cheers,

Jeff

Attachment Content-Type Size
cluster_verbose_complete_v2.patch application/octet-stream 2.3 KB

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Jeff Janes <jeff(dot)janes(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: "CLUSTER VERBOSE" tab completion
Date: 2012-08-20 20:46:45
Message-ID: CA+TgmobCh4fRk3MjDKKCqHWXNfAVNaOWpHkJhjnshLa9yxBsUg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Sun, Aug 19, 2012 at 4:55 PM, Jeff Janes <jeff(dot)janes(at)gmail(dot)com> wrote:
> On Fri, Aug 17, 2012 at 7:18 PM, Jeff Janes <jeff(dot)janes(at)gmail(dot)com> wrote:
>> tab completion will add "USING" after CLUSTER VERBOSE, as if VERBOSE
>> were the name of a table.
>>
>> Instead of just making it not do the wrong thing, I tried to make it
>> actually do the right thing.
>>
>> It doesn't fill in the VERBOSE for you, you have to type that in full,
>
> This short coming has now been rectified.

Committed this one too. Thanks for the patch.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company