| Lists: | pgsql-hackers |
|---|
| From: | didier <did447(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | trivial one-off memory leak in guc-file.l ParseConfigFile |
| Date: | 2013-09-22 19:40:27 |
| Message-ID: | CAJRYxuJaiEJVyYP5OkP3KrnHCaW3u_7470Uur7gQ1iA2aQ6Arg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Hi
fix a small memory leak in guc-file.l ParseConfigFile
AbsoluteConfigLocation() return a strdup string but it's never free or
referenced outside ParseConfigFile
Courtesy Valgrind and Noah Misch MEMPOOL work.
Regards
Didier
| Attachment | Content-Type | Size |
|---|---|---|
| memory_leak_in_parse_config_file.patch | application/octet-stream | 1.5 KB |
| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | didier <did447(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: trivial one-off memory leak in guc-file.l ParseConfigFile |
| Date: | 2013-09-24 15:06:23 |
| Message-ID: | CA+TgmoatHxzBrTF9rFNWbyCpzP4_zfNycVGUet9Y3q+YiyRdBg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Sun, Sep 22, 2013 at 3:40 PM, didier <did447(at)gmail(dot)com> wrote:
> fix a small memory leak in guc-file.l ParseConfigFile
>
> AbsoluteConfigLocation() return a strdup string but it's never free or
> referenced outside ParseConfigFile
>
> Courtesy Valgrind and Noah Misch MEMPOOL work.
I'd like to look at this, but I haven't got time right now. Could you
add it to the next CommitFest so it doesn't get forgotten about?
https://commitfest.postgresql.org/action/commitfest_view/open
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
|---|---|
| To: | didier <did447(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: trivial one-off memory leak in guc-file.l ParseConfigFile |
| Date: | 2013-11-15 18:20:10 |
| Message-ID: | 528665DA.2070302@vmware.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On 22.09.2013 22:40, didier wrote:
> Hi
>
> fix a small memory leak in guc-file.l ParseConfigFile
>
> AbsoluteConfigLocation() return a strdup string but it's never free or
> referenced outside ParseConfigFile
>
> Courtesy Valgrind and Noah Misch MEMPOOL work.
I spotted and fixed this some time ago while fixing another leak, see
http://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=138184adc5f7c60c184972e4d23f8cdb32aed77d.
I didn't realize you had already reported it back then.
So, I've marked this as committed in the commitfest app. But thanks for
the report anyway.
- Heikki