| Lists: | pgsql-hackers |
|---|
| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | replication commands and index terms |
| Date: | 2014-08-14 16:59:36 |
| Message-ID: | CAHGQGwFvG3fOLWSbAT2MJ=zX7WpWL-JBFSbrkAYM29oAmoaTWg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Hi,
I found that only CREATE_REPLICATION_SLOT of replication commands
is exposed as an index term in the document. Is this intentional?
If not, for the consistency, I think that we should either expose other
replication commands also as index terms, or remove
CREATE_REPLICATION_SLOT from the index. Thought?
Since I sometimes try to search the replication command in the index,
I'd feel inclined to expose all those commands as index terms...
Regards,
--
Fujii Masao
| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: replication commands and index terms |
| Date: | 2014-08-14 19:59:49 |
| Message-ID: | CA+TgmoZvX=+aAY1B5RpT=Pcc7ONuS_8UPDQJw-H3pKnh6pQiyg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Thu, Aug 14, 2014 at 12:59 PM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> Since I sometimes try to search the replication command in the index,
> I'd feel inclined to expose all those commands as index terms...
+1.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: replication commands and index terms |
| Date: | 2014-08-15 02:25:47 |
| Message-ID: | CAHGQGwFuwEMWjV9WH_wr2RZQD5UKxyPRhu2Mcevq5TLxF=Be=A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Fri, Aug 15, 2014 at 4:59 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Thu, Aug 14, 2014 at 12:59 PM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>> Since I sometimes try to search the replication command in the index,
>> I'd feel inclined to expose all those commands as index terms...
>
> +1.
Attached patch exposes replication commands as index terms.
Barring any objection, I will commit this.
Regards,
--
Fujii Masao
| Attachment | Content-Type | Size |
|---|---|---|
| expose_replication_commands_as_index_terms_v1.patch | text/x-patch | 5.1 KB |
| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: replication commands and index terms |
| Date: | 2014-08-18 02:38:31 |
| Message-ID: | CAHGQGwFuN4Ekw7Av488=zCBLp5mrF9iEC5-87dpGQf4v6KTHbA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Fri, Aug 15, 2014 at 11:25 AM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> On Fri, Aug 15, 2014 at 4:59 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> On Thu, Aug 14, 2014 at 12:59 PM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>>> Since I sometimes try to search the replication command in the index,
>>> I'd feel inclined to expose all those commands as index terms...
>>
>> +1.
>
> Attached patch exposes replication commands as index terms.
> Barring any objection, I will commit this.
Done.
Regards,
--
Fujii Masao