| Lists: | pgsql-hackers |
|---|
| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Improvement of log messages in pg_basebackup |
| Date: | 2012-03-27 09:25:27 |
| Message-ID: | CAHGQGwEbvxuDSCoT6EG+RiEp7-O6Wp+ozzEYnJmpmfsYpc9yqg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Hi,
> fprintf(stderr, _("%s: could not identify system: %s\n"),
> progname, PQerrorMessage(conn));
Since PQerrorMessage() result includes a trailing newline, the above
log message in pg_basebackup doesn't need to include a trailing \n.
Attached patch gets rid of that \n.
> res = PQgetResult(conn);
> if (PQresultStatus(res) != PGRES_TUPLES_OK)
> {
> fprintf(stderr, _("%s: could not get WAL end position from server\n"),
> progname);
ISTM it's worth including PQerrorMessage() result in the above log
message, to diagnose the cause of error. Attached patch does that.
Regards,
--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
| Attachment | Content-Type | Size |
|---|---|---|
| improve_pg_basebackup_log_messages_v1.patch | text/x-diff | 1.1 KB |
| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Improvement of log messages in pg_basebackup |
| Date: | 2012-03-28 12:44:17 |
| Message-ID: | CA+TgmoboGtNSxVptC-zSKGa1+qum0Y_YGtTq77nVwGXPbeixNw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Tue, Mar 27, 2012 at 5:25 AM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>> fprintf(stderr, _("%s: could not identify system: %s\n"),
>> progname, PQerrorMessage(conn));
>
> Since PQerrorMessage() result includes a trailing newline, the above
> log message in pg_basebackup doesn't need to include a trailing \n.
> Attached patch gets rid of that \n.
>
>> res = PQgetResult(conn);
>> if (PQresultStatus(res) != PGRES_TUPLES_OK)
>> {
>> fprintf(stderr, _("%s: could not get WAL end position from server\n"),
>> progname);
>
> ISTM it's worth including PQerrorMessage() result in the above log
> message, to diagnose the cause of error. Attached patch does that.
Committed.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company