| Lists: | pgsql-hackers |
|---|
| From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Cc: | Fabrízio Mello <fabriziomello(at)gmail(dot)com> |
| Subject: | review: create if not exists |
| Date: | 2013-11-24 21:18:20 |
| Message-ID: | CAFj8pRCp6rhBidsHUGhY6fLqin2zDJwi_wxMd-hhV0-wP5Bd+A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Hello,
this patch introduces IF NOT EXISTS clause to CREATE (AGGREGATE | CAST
|COLATION |DOMAIN |ROLE |SEQUENCE |SEARCH CONFIGURATION |SEARCH DICTIONARY
| SEARCH PARSE | SEARCH TEMPLATE | TYPE). Implemented feature was discussed
more times in spring and summer, and this patch was ready for commit in
summer. Fabrízio reflected all reviewers comments. I primary checked a
consistency of related patch.
* all new functionality (syntax) is well documented
* there are no any compilation warning related to implemented feature
* all new functionality is tested in regress tests
* new code fully respects PostgreSQL coding standards
* new code is almost mechanical - and enough documented
* new functionality has no impact on performance
* new functionality doesn't need a changes in pg_dump
This patch is ready for commit
Regards
Pavel Stehule
| From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: review: create if not exists |
| Date: | 2013-11-24 21:19:11 |
| Message-ID: | CAFj8pRDt6Me=+6wd8UpS1b2HrS9R=1JpXBJk+2w_+B2bif3KTg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
sorry
+
* all regress tests passed without error
2013/11/24 Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
> Hello,
>
> this patch introduces IF NOT EXISTS clause to CREATE (AGGREGATE | CAST
> |COLATION |DOMAIN |ROLE |SEQUENCE |SEARCH CONFIGURATION |SEARCH DICTIONARY
> | SEARCH PARSE | SEARCH TEMPLATE | TYPE). Implemented feature was discussed
> more times in spring and summer, and this patch was ready for commit in
> summer. Fabrízio reflected all reviewers comments. I primary checked a
> consistency of related patch.
>
> * all new functionality (syntax) is well documented
> * there are no any compilation warning related to implemented feature
> * all new functionality is tested in regress tests
> * new code fully respects PostgreSQL coding standards
> * new code is almost mechanical - and enough documented
> * new functionality has no impact on performance
> * new functionality doesn't need a changes in pg_dump
>
> This patch is ready for commit
>
> Regards
>
> Pavel Stehule
>
>