review: WITH CHECK OPTION

Lists: pgsql-hackers
From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Cc: Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>
Subject: review: WITH CHECK OPTION
Date: 2013-07-06 04:25:22
Message-ID: CAFj8pRAr11OEtfLutBHhuk9Px5XBX5Euq9hixpZut7EBiOGWrg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Hello

0) we would this feature
* it is finalization of ANSI SQL feature, that is complete now
* it is useful feature, than moves work with updatable views close to heaps

1) patch is cleanly applied
2) there are no new warnings
3) all regress tests was passed - there are enough tests for this feature
4) doc was rebuilt without problems and it is well documented
5) a implemented feature is ANSI SQL compliant
6) code is clean, well commented and well formatted
7) it works as expected

This patch is ready for commit

Regards

Pavel Stehule