| Lists: | pgsql-hackers |
|---|
| From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Subject: | review: psql tab completion for GRANT role |
| Date: | 2012-01-17 12:03:50 |
| Message-ID: | CAFj8pRA+OzQ5ghE9Z2FJ5knYMb1JJiFjY-L1k-4WUmMSJrtAKw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Hello
I did review of this small patch
http://archives.postgresql.org/message-id/1326055692.15293.15.camel@vanquo.pezone.net
* This patch was applied without with one hunk and compiled without warnings
bash-4.2$ patch -p1 < autocompleta.patch
patching file src/bin/psql/tab-complete.c
Hunk #2 succeeded at 2335 with fuzz 1.
* all regress tests was processed
* this patch respect Pg coding standards
* code is simple and has not impact on core functionality or core performance
* regress tests are not requested for interactive function
* I checked it, and autocomplete has expected behave.
It is ready for commit
Regards
Pavel Stehule
| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: review: psql tab completion for GRANT role |
| Date: | 2012-01-21 17:48:39 |
| Message-ID: | 1327168119.4482.4.camel@vanquo.pezone.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On tis, 2012-01-17 at 13:03 +0100, Pavel Stehule wrote:
> Hello
>
> I did review of this small patch
> http://archives.postgresql.org/message-id/1326055692.15293.15.camel@vanquo.pezone.net
>
> * This patch was applied without with one hunk and compiled without warnings
>
> bash-4.2$ patch -p1 < autocompleta.patch
> patching file src/bin/psql/tab-complete.c
> Hunk #2 succeeded at 2335 with fuzz 1.
>
> * all regress tests was processed
>
> * this patch respect Pg coding standards
> * code is simple and has not impact on core functionality or core performance
> * regress tests are not requested for interactive function
> * I checked it, and autocomplete has expected behave.
>
> It is ready for commit
Committed, thanks.