| Lists: | pgsql-bugs |
|---|
| From: | Peter Geoghegan <peter(at)2ndquadrant(dot)com> |
|---|---|
| To: | Pg Bugs <pgsql-bugs(at)postgresql(dot)org> |
| Subject: | Incorrect comment in heapam.c |
| Date: | 2011-12-20 17:50:37 |
| Message-ID: | CAEYLb_VYydAMMfqh_RrHkdtszNU-Gh78zxbjfRSafHBgOeJrUg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-bugs |
Line 834 of heapam.c has the following comment:
/*
* This is formatted so oddly so that the correspondence to the macro
* definition in access/heapam.h is maintained.
*/
In fact, that macro is defined in access/htup.h...should it be?
--
Peter Geoghegan http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training and Services
| From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
|---|---|
| To: | Peter Geoghegan <peter(at)2ndquadrant(dot)com> |
| Cc: | Pg Bugs <pgsql-bugs(at)postgresql(dot)org> |
| Subject: | Re: Incorrect comment in heapam.c |
| Date: | 2011-12-20 17:53:38 |
| Message-ID: | CA+U5nM+xabfzUTXUHp7qJDo=2oHXfL7b_eFnxOArzr-UVX4heA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-bugs |
On Tue, Dec 20, 2011 at 5:50 PM, Peter Geoghegan <peter(at)2ndquadrant(dot)com> wrote:
> Line 834 of heapam.c has the following comment:
>
> /*
> * This is formatted so oddly so that the correspondence to the macro
> * definition in access/heapam.h is maintained.
> */
>
> In fact, that macro is defined in access/htup.h...should it be?
IMHO comment is wrong, code is in the right place.
--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
| Cc: | Peter Geoghegan <peter(at)2ndQuadrant(dot)com>, Pg Bugs <pgsql-bugs(at)postgresql(dot)org> |
| Subject: | Re: Incorrect comment in heapam.c |
| Date: | 2011-12-20 18:11:36 |
| Message-ID: | 10219.1324404696@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-bugs |
Simon Riggs <simon(at)2ndQuadrant(dot)com> writes:
> On Tue, Dec 20, 2011 at 5:50 PM, Peter Geoghegan <peter(at)2ndquadrant(dot)com> wrote:
>> In fact, that macro is defined in access/htup.h...should it be?
> IMHO comment is wrong, code is in the right place.
It used to be in heapam.h ... evidently, whoever moved it missed this
comment.
regards, tom lane
| From: | Peter Geoghegan <peter(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Simon Riggs <simon(at)2ndquadrant(dot)com>, Pg Bugs <pgsql-bugs(at)postgresql(dot)org> |
| Subject: | Re: Incorrect comment in heapam.c |
| Date: | 2011-12-21 11:21:44 |
| Message-ID: | CAEYLb_Vj0hPM5-0Uto_L14OFVf2KbpTvEpDn4qxTEqoz+5kHSw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-bugs |
On 20 December 2011 18:11, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Simon Riggs <simon(at)2ndQuadrant(dot)com> writes:
>> On Tue, Dec 20, 2011 at 5:50 PM, Peter Geoghegan <peter(at)2ndquadrant(dot)com> wrote:
>>> In fact, that macro is defined in access/htup.h...should it be?
>
>> IMHO comment is wrong, code is in the right place.
>
> It used to be in heapam.h ... evidently, whoever moved it missed this
> comment.
I imagined that that was the case.
It's a fairly inconsequential bug, but it is worth fixing...
--
Peter Geoghegan http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training and Services
| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Peter Geoghegan <peter(at)2ndquadrant(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Pg Bugs <pgsql-bugs(at)postgresql(dot)org> |
| Subject: | Re: Incorrect comment in heapam.c |
| Date: | 2012-01-17 01:37:52 |
| Message-ID: | CA+TgmoY0uA3PtUeF85GsU=OAZQniL76+un58fO0rQsGk0bYkCQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-bugs |
On Wed, Dec 21, 2011 at 6:21 AM, Peter Geoghegan <peter(at)2ndquadrant(dot)com> wrote:
> On 20 December 2011 18:11, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Simon Riggs <simon(at)2ndQuadrant(dot)com> writes:
>>> On Tue, Dec 20, 2011 at 5:50 PM, Peter Geoghegan <peter(at)2ndquadrant(dot)com> wrote:
>>>> In fact, that macro is defined in access/htup.h...should it be?
>>
>>> IMHO comment is wrong, code is in the right place.
>>
>> It used to be in heapam.h ... evidently, whoever moved it missed this
>> comment.
>
> I imagined that that was the case.
>
> It's a fairly inconsequential bug, but it is worth fixing...
Fixed.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From: | Peter Geoghegan <peter(at)2ndquadrant(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Pg Bugs <pgsql-bugs(at)postgresql(dot)org> |
| Subject: | Re: Incorrect comment in heapam.c |
| Date: | 2012-01-17 12:52:24 |
| Message-ID: | CAEYLb_UMssVfMh1ofxx3Ru5c5ouPu33r-uZ00GgdmH_RitV32w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-bugs |
On 17 January 2012 01:37, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> It's a fairly inconsequential bug, but it is worth fixing...
>
> Fixed.
Thanks.
--
Peter Geoghegan http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training and Services