| Lists: | pgsql-hackers |
|---|
| From: | Robins Tharakan <tharakan(at)gmail(dot)com> |
|---|---|
| To: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Add more regression tests for ASYNC |
| Date: | 2013-05-14 00:37:49 |
| Message-ID: | CAEP4nAxn_NcXyykGaLjxbLJoS3ShQWcFJq8asxBymmBe5UQSSg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Hi,
Patch to add more regression tests to ASYNC (/src/backend/commands/async).
Take code-coverage from 39% to 75%.
Any and all feedback is obviously welcome.
p.s.: Please let me know whether these tests are useless or would not be
committed owing to unrelated reasons. As also, if these tests need to be
clubbed (bundled up in 2-3) and submitted as a single submit.
--
Robins Tharakan
| Attachment | Content-Type | Size |
|---|---|---|
| regress_async.patch | application/octet-stream | 2.3 KB |
| From: | Josh Berkus <josh(at)agliodbs(dot)com> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Add more regression tests for ASYNC |
| Date: | 2013-06-28 19:42:47 |
| Message-ID: | 51CDE737.9000507@agliodbs.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On 05/13/2013 05:37 PM, Robins Tharakan wrote:
> Hi,
>
> Patch to add more regression tests to ASYNC (/src/backend/commands/async).
> Take code-coverage from 39% to 75%.
This isn't applying for me anymore due to changes in the
parallel_schedule file. Where did you mean this to execute in the
sequence of tests?
--- src/test/regress/parallel_schedule
+++ src/test/regress/parallel_schedule
@@ -88,7 +88,7 @@
# ----------
# Another group of parallel tests
# ----------
-test: alter_generic misc psql
+test: alter_generic misc psql async
# rules cannot run concurrently with any test that creates a view
test: rules
--
Josh Berkus
PostgreSQL Experts Inc.
http://pgexperts.com
| From: | Josh Berkus <josh(at)agliodbs(dot)com> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Add more regression tests for ASYNC |
| Date: | 2013-06-28 19:58:43 |
| Message-ID: | 51CDEAF3.9030800@agliodbs.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On 06/28/2013 12:42 PM, Josh Berkus wrote:
> On 05/13/2013 05:37 PM, Robins Tharakan wrote:
>> Hi,
>>
>> Patch to add more regression tests to ASYNC (/src/backend/commands/async).
>> Take code-coverage from 39% to 75%.
>
> This isn't applying for me anymore due to changes in the
> parallel_schedule file. Where did you mean this to execute in the
> sequence of tests?
Never mind, dirty checkout on my part. Back to testing.
--
Josh Berkus
PostgreSQL Experts Inc.
http://pgexperts.com
| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Robins Tharakan <tharakan(at)gmail(dot)com> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Add more regression tests for ASYNC |
| Date: | 2013-07-03 15:08:01 |
| Message-ID: | CA+TgmoZUXLqnzLr1gkXdCKt1HOQpof5cpCbc_HVMNMEtNSf=Sw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Mon, May 13, 2013 at 8:37 PM, Robins Tharakan <tharakan(at)gmail(dot)com> wrote:
> Hi,
>
> Patch to add more regression tests to ASYNC (/src/backend/commands/async).
> Take code-coverage from 39% to 75%.
>
> Any and all feedback is obviously welcome.
>
> p.s.: Please let me know whether these tests are useless or would not be
> committed owing to unrelated reasons. As also, if these tests need to be
> clubbed (bundled up in 2-3) and submitted as a single submit.
Committed.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company