| Lists: | pgsql-hackers |
|---|
| From: | Mark Dilger <hornschnorter(at)gmail(dot)com> |
|---|---|
| To: | heikki(dot)linnakangas(at)iki(dot)fi, pgsql-hackers(at)postgresql(dot)org |
| Subject: | duplicate #define |
| Date: | 2014-12-13 14:45:57 |
| Message-ID: | CAE-h2ToB6b2h=GnOpOMn2kCPo5-fhSg4nNGovxGhTfjexEhv1w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
In commit 2c03216d831160bedd72d45f712601b6f7d03f1c, the
following define occurs twice in src/include/access/xlogrecord.h:
#define SizeOfXLogRecordDataHeaderLong (sizeof(uint8) + sizeof(uint32))
It is no big deal, as the definitions don't contradict each other. We
could probably live with just one, though.
Patch attached
Mark Dilger
| Attachment | Content-Type | Size |
|---|---|---|
| xlogrecord.diff | text/plain | 428 bytes |
| From: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
|---|---|
| To: | Mark Dilger <hornschnorter(at)gmail(dot)com>, <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: duplicate #define |
| Date: | 2014-12-13 16:22:44 |
| Message-ID: | 548C67D4.2020107@vmware.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On 12/13/2014 04:45 PM, Mark Dilger wrote:
> In commit 2c03216d831160bedd72d45f712601b6f7d03f1c, the
> following define occurs twice in src/include/access/xlogrecord.h:
>
> #define SizeOfXLogRecordDataHeaderLong (sizeof(uint8) + sizeof(uint32))
>
> It is no big deal, as the definitions don't contradict each other. We
> could probably live with just one, though.
>
> Patch attached
Thanks, fixed!
- Heikki