Re: [PATCH] empty xml values

Lists: pgsql-hackers
From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: [PATCH] empty xml values
Date: 2014-05-12 00:30:03
Message-ID: 5370160B.5040106@gmx.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

While looking into this report
http://www.postgresql.org/message-id/CF48CCFB.65A9D%tim.kane@gmail.com I
noticed that we don't accept empty values as xml "content" values, even
though this should apparently be allowed by the spec. Attached is a
patch to fix it (which needs updates to xml_1.out, which I omit here for
simplicity).

Attachment Content-Type Size
xml-empty.patch text/x-patch 2.6 KB
From: Ali Akbar <the(dot)apaan(at)gmail(dot)com>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] empty xml values
Date: 2014-08-30 16:43:38
Message-ID: CACQjQLrb=z19bP2UyA-HKboA65Gu73uwJ+y81tOkZw37B7QnEA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

>
> While looking into this report
> http://www.postgresql.org/message-id/CF48CCFB.65A9D%tim.kane@gmail.com I
> noticed that we don't accept empty values as xml "content" values, even
> though this should apparently be allowed by the spec. Attached is a
> patch to fix it (which needs updates to xml_1.out, which I omit here for
> simplicity).
>

The patch works, albeit must be applied with --ignore-whitespace. Attached
the patch + xml_1.out updates.

I'm marking this ready for commit
--
Ali Akbar

Attachment Content-Type Size
xml-empty-add-xml_1.patch text/x-patch 4.7 KB
From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Ali Akbar <the(dot)apaan(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] empty xml values
Date: 2014-09-09 15:39:53
Message-ID: 540F1F49.3070105@gmx.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 8/30/14 12:43 PM, Ali Akbar wrote:
> While looking into this report
> http://www.postgresql.org/message-id/CF48CCFB.65A9D%tim.kane@gmail.com I
> noticed that we don't accept empty values as xml "content" values, even
> though this should apparently be allowed by the spec. Attached is a
> patch to fix it (which needs updates to xml_1.out, which I omit here for
> simplicity).
>
>
> The patch works, albeit must be applied with --ignore-whitespace.
> Attached the patch + xml_1.out updates.
>
> I'm marking this ready for commit

Committed, thanks.