Re: [HACKERS] pgindent README correction

I found that I needed to adjust the command given in the README file
for pgindent. Trivial patch attached.

The one other issue I ran into in following the latest pgindent
instructions was that I had to add #include <stdlib.h> to the
parse.c file (as included in the pg_bsd_indent-1.1.tar.gz file at
ftp://ftp.postgresql.org/pub/dev ). Without it I got this:

parse.c: In function *parse*:
parse.c:236:6: warning: implicit declaration of function *exit*
parse.c:236:6: warning: incompatible implicit declaration of built-in
function *exit*

Can someone fix that and put up a 1.2 version?

-Kevin

On Mon, Jan 9, 2012 at 12:31 PM, Kevin Grittner
<Kevin(dot)Grittner(at)wicourts(dot)gov> wrote:
> I found that I needed to adjust the command given in the README file
> for pgindent.  Trivial patch attached.

Committed.

> The one other issue I ran into in following the latest pgindent
> instructions was that I had to add #include <stdlib.h> to the
> parse.c file (as included in the pg_bsd_indent-1.1.tar.gz file at
> ftp://ftp.postgresql.org/pub/dev ).  Without it I got this:
>
> parse.c: In function *parse*:
> parse.c:236:6: warning: implicit declaration of function *exit*
> parse.c:236:6: warning: incompatible implicit declaration of built-in
> function *exit*
>
> Can someone fix that and put up a 1.2 version?

Sounds like a job for Mr. Momjian.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Mon, Jan 09, 2012 at 01:32:49PM -0500, Robert Haas wrote:
> > The one other issue I ran into in following the latest pgindent
> > instructions was that I had to add #include <stdlib.h> to the
> > parse.c file (as included in the pg_bsd_indent-1.1.tar.gz file at
> > ftp://ftp.postgresql.org/pub/dev ).  Without it I got this:
> >
> > parse.c: In function *parse*:
> > parse.c:236:6: warning: implicit declaration of function *exit*
> > parse.c:236:6: warning: incompatible implicit declaration of built-in
> > function *exit*
> >
> > Can someone fix that and put up a 1.2 version?
>
> Sounds like a job for Mr. Momjian.

What server do I log into to update the ftp pgindent tgz file?

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

On Wednesday, February 8, 2012, Bruce Momjian wrote:

> On Mon, Jan 09, 2012 at 01:32:49PM -0500, Robert Haas wrote:
> > > The one other issue I ran into in following the latest pgindent
> > > instructions was that I had to add #include <stdlib.h> to the
> > > parse.c file (as included in the pg_bsd_indent-1.1.tar.gz file at
> > > ftp://ftp.postgresql.org/pub/dev ). Without it I got this:
> > >
> > > parse.c: In function *parse*:
> > > parse.c:236:6: warning: implicit declaration of function *exit*
> > > parse.c:236:6: warning: incompatible implicit declaration of built-in
> > > function *exit*
> > >
> > > Can someone fix that and put up a 1.2 version?
> >
> > Sounds like a job for Mr. Momjian.
>
> What server do I log into to update the ftp pgindent tgz file?
>

The ftp master server is fornax.postgresql.org.

//Magnus

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/

On Wed, Feb 8, 2012 at 8:13 AM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
> On Wednesday, February 8, 2012, Bruce Momjian wrote:
>>
>> On Mon, Jan 09, 2012 at 01:32:49PM -0500, Robert Haas wrote:
>> > > The one other issue I ran into in following the latest pgindent
>> > > instructions was that I had to add #include <stdlib.h> to the
>> > > parse.c file (as included in the pg_bsd_indent-1.1.tar.gz file at
>> > > ftp://ftp.postgresql.org/pub/dev ).  Without it I got this:
>> > >
>> > > parse.c: In function *parse*:
>> > > parse.c:236:6: warning: implicit declaration of function *exit*
>> > > parse.c:236:6: warning: incompatible implicit declaration of built-in
>> > > function *exit*
>> > >
>> > > Can someone fix that and put up a 1.2 version?
>> >
>> > Sounds like a job for Mr. Momjian.
>>
>> What server do I log into to update the ftp pgindent tgz file?
>
>
> The ftp master server is fornax.postgresql.org.

Though, you should bookmark ftpmaster.postgresql.org which will always
point to the master FTP server even if it moves to a different host.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Mon, Jan 9, 2012 at 11:31:02AM -0600, Kevin Grittner wrote:
> I found that I needed to adjust the command given in the README file
> for pgindent. Trivial patch attached.
>
> The one other issue I ran into in following the latest pgindent
> instructions was that I had to add #include <stdlib.h> to the
> parse.c file (as included in the pg_bsd_indent-1.1.tar.gz file at
> ftp://ftp.postgresql.org/pub/dev ). Without it I got this:
>
> parse.c: In function *parse*:
> parse.c:236:6: warning: implicit declaration of function *exit*
> parse.c:236:6: warning: incompatible implicit declaration of built-in
> function *exit*
>
> Can someone fix that and put up a 1.2 version?

Done. Please give the ftp mirrors a little while to update, but you can
get pg_bsd_indent 1.2 now at ftpmaster.postgresql.org. pgindent was
also updated to require the 1.2 version.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +