| Lists: | pgsql-hackers |
|---|
| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Missing autocomplete for CREATE DATABASE |
| Date: | 2014-07-10 19:32:01 |
| Message-ID: | CABUevEwatLsc7ARP5RJ9c8cyc_anYdXMLbVAg377FXio1-hfeg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
It seems psql is missing autocomplete entries for LC_COLLATE and
LC_CTYPE for the CREATE DATABASE command. Attached patch adds that.
I doubt this is important enough to backpatch - thoughts?
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
| Attachment | Content-Type | Size |
|---|---|---|
| psql_locale_autocomplete.patch | text/x-patch | 457 bytes |
| From: | Vik Fearing <vik(dot)fearing(at)dalibo(dot)com> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Missing autocomplete for CREATE DATABASE |
| Date: | 2014-07-10 22:01:10 |
| Message-ID: | 53BF0D26.4030708@dalibo.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On 07/10/2014 09:32 PM, Magnus Hagander wrote:
> It seems psql is missing autocomplete entries for LC_COLLATE and
> LC_CTYPE for the CREATE DATABASE command. Attached patch adds that.
>
> I doubt this is important enough to backpatch - thoughts?
It won't apply to current head, but otherwise I see no problem with it.
I have no opinion on backpatching it.
--
Vik
| From: | David Fetter <david(at)fetter(dot)org> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Missing autocomplete for CREATE DATABASE |
| Date: | 2014-07-10 22:46:43 |
| Message-ID: | 20140710224643.GM339@fetter.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Thu, Jul 10, 2014 at 08:32:01PM +0100, Magnus Hagander wrote:
> It seems psql is missing autocomplete entries for LC_COLLATE and
> LC_CTYPE for the CREATE DATABASE command. Attached patch adds that.
>
> I doubt this is important enough to backpatch - thoughts?
I don't see how it could hurt to fix this bug.
Cheers,
David.
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com
iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics
Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate
| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Vik Fearing <vik(dot)fearing(at)dalibo(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Missing autocomplete for CREATE DATABASE |
| Date: | 2014-07-11 11:10:06 |
| Message-ID: | CABUevEzeq=JvjEKy2JZpms1Tn5F=5nDOMndBVwAchu1wn1NYmw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Fri, Jul 11, 2014 at 12:01 AM, Vik Fearing <vik(dot)fearing(at)dalibo(dot)com> wrote:
> On 07/10/2014 09:32 PM, Magnus Hagander wrote:
>> It seems psql is missing autocomplete entries for LC_COLLATE and
>> LC_CTYPE for the CREATE DATABASE command. Attached patch adds that.
>>
>> I doubt this is important enough to backpatch - thoughts?
>
> It won't apply to current head, but otherwise I see no problem with it.
Meh, thanks for pointing that out. I git-fetch:ed from the wrong repository :)
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Vik Fearing <vik(dot)fearing(at)dalibo(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Missing autocomplete for CREATE DATABASE |
| Date: | 2014-07-12 12:23:34 |
| Message-ID: | CABUevEwLP3gmY60fusB7aVqj6cFrfBpC2aFfuJoQw7oAsj6KnQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Fri, Jul 11, 2014 at 1:10 PM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
> On Fri, Jul 11, 2014 at 12:01 AM, Vik Fearing <vik(dot)fearing(at)dalibo(dot)com> wrote:
>> On 07/10/2014 09:32 PM, Magnus Hagander wrote:
>>> It seems psql is missing autocomplete entries for LC_COLLATE and
>>> LC_CTYPE for the CREATE DATABASE command. Attached patch adds that.
>>>
>>> I doubt this is important enough to backpatch - thoughts?
>>
>> It won't apply to current head, but otherwise I see no problem with it.
>
> Meh, thanks for pointing that out. I git-fetch:ed from the wrong repository :)
Applied and backpatched.
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/