| Lists: | pgsql-hackers |
|---|
| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | git author vs committer |
| Date: | 2012-09-12 14:21:36 |
| Message-ID: | 1347459696.16215.11.camel@vanquo.pezone.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
A while ago I wanted to cherry-pick a patch from master to a back-branch
that was initially committed by someone else. That was rejected because
our git server requires author==committer. I don't think that
restriction is particularly useful and should be lifted. I'm not saying
we should let anyone be an author, but within the pool of committers, I
think we should let the mechanics of the git tools determine these
fields.
| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: git author vs committer |
| Date: | 2012-09-12 14:48:09 |
| Message-ID: | 1347461226-sup-7608@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Excerpts from Peter Eisentraut's message of mié sep 12 11:21:36 -0300 2012:
> A while ago I wanted to cherry-pick a patch from master to a back-branch
> that was initially committed by someone else. That was rejected because
> our git server requires author==committer. I don't think that
> restriction is particularly useful and should be lifted. I'm not saying
> we should let anyone be an author, but within the pool of committers, I
> think we should let the mechanics of the git tools determine these
> fields.
+1. I had the same problem.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: git author vs committer |
| Date: | 2012-09-12 17:13:01 |
| Message-ID: | CABUevEw1nvJpyzxNEBhxT7u0wzWV3BJxvDi7dhtMCbPw3b5OLQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Wed, Sep 12, 2012 at 4:21 PM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
> A while ago I wanted to cherry-pick a patch from master to a back-branch
> that was initially committed by someone else. That was rejected because
> our git server requires author==committer. I don't think that
> restriction is particularly useful and should be lifted. I'm not saying
> we should let anyone be an author, but within the pool of committers, I
> think we should let the mechanics of the git tools determine these
> fields.
Just to be clear, what you're saying is we want to change the policy
that says "committer must be on list of approved committers &&
commiter==author" to "committer must be on list of approved committers
&& author must be on list of approved committers"?
Assuming that's what you meant, there is no support for that in the
scripts now, but if we agree that's a good thing it should be trivial
to add it.
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: git author vs committer |
| Date: | 2012-09-12 17:34:59 |
| Message-ID: | 29348.1347471299@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Magnus Hagander <magnus(at)hagander(dot)net> writes:
> Just to be clear, what you're saying is we want to change the policy
> that says "committer must be on list of approved committers &&
> commiter==author" to "committer must be on list of approved committers
> && author must be on list of approved committers"?
Works for me.
regards, tom lane
| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: git author vs committer |
| Date: | 2012-09-13 03:22:50 |
| Message-ID: | 1347506570.18266.0.camel@vanquo.pezone.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Wed, 2012-09-12 at 19:13 +0200, Magnus Hagander wrote:
> Just to be clear, what you're saying is we want to change the policy
> that says "committer must be on list of approved committers &&
> commiter==author" to "committer must be on list of approved committers
> && author must be on list of approved committers"?
Yes, that would be my request.
| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: git author vs committer |
| Date: | 2012-09-13 07:00:14 |
| Message-ID: | CABUevEwWF1CEJ588tsUCVdOSbmuSbB=YixNjAK4QJSQWk3P+gw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Thu, Sep 13, 2012 at 5:22 AM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
> On Wed, 2012-09-12 at 19:13 +0200, Magnus Hagander wrote:
>> Just to be clear, what you're saying is we want to change the policy
>> that says "committer must be on list of approved committers &&
>> commiter==author" to "committer must be on list of approved committers
>> && author must be on list of approved committers"?
>
> Yes, that would be my request.
Definitely sounds like a reasonable thing to do. So unless there are
objections, I'll try to get around to getting that done not too long
from now.
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: git author vs committer |
| Date: | 2013-01-05 17:21:54 |
| Message-ID: | CABUevExfR257hV5RzvNGVDnNQtaSvJP+XB-chCmCwtE28dmh_A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Thu, Sep 13, 2012 at 9:00 AM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
> On Thu, Sep 13, 2012 at 5:22 AM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
>> On Wed, 2012-09-12 at 19:13 +0200, Magnus Hagander wrote:
>>> Just to be clear, what you're saying is we want to change the policy
>>> that says "committer must be on list of approved committers &&
>>> commiter==author" to "committer must be on list of approved committers
>>> && author must be on list of approved committers"?
>>
>> Yes, that would be my request.
>
> Definitely sounds like a reasonable thing to do. So unless there are
> objections, I'll try to get around to getting that done not too long
> from now.
Sorry, this took much longer than I had initially planned for, but at
least it's been done now. Hopefully I didn't break anything else in
the process :)
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/