[PATCH] pg_test_fsync: Delete temporary file when aborted by a signal

Lists: pgsql-hackers
From: Marti Raudsepp <marti(at)juffo(dot)org>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: [PATCH] pg_test_fsync: Delete temporary file when aborted by a signal
Date: 2011-12-07 18:40:51
Message-ID: CABRT9RAa5XX4hxkqg9zspLeA+H2DvVT75VoqzbpDgeamdAS_zA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Hi list,

I found a 'pg_test_fsync.out' file in my $PGDATA, which was probably
left around because I aborted pg_test_fsync with ^C back when setting
up the server.

Here's a patch to delete that file via a signal handler for
SIGINT/SIGTERM/SIGHUP.

Not tested on Windows, but should work according to MSDN documentation.

Regards,
Marti

Attachment Content-Type Size
0001-pg_test_fsync-Delete-temporary-file-when-aborted-by-.patch text/x-patch 1.6 KB

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Marti Raudsepp <marti(at)juffo(dot)org>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] pg_test_fsync: Delete temporary file when aborted by a signal
Date: 2011-12-09 20:07:34
Message-ID: CA+TgmoYbpBFnHvO9OcPW9GHvH_FCAQgPU9s+9szS-jUUaAMAbg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Wed, Dec 7, 2011 at 1:40 PM, Marti Raudsepp <marti(at)juffo(dot)org> wrote:
> Hi list,
>
> I found a 'pg_test_fsync.out' file in my $PGDATA, which was probably
> left around because I aborted pg_test_fsync with ^C back when setting
> up the server.
>
> Here's a patch to delete that file via a signal handler for
> SIGINT/SIGTERM/SIGHUP.
>
> Not tested on Windows, but should work according to MSDN documentation.

I committed this, with a bit of additional paranoia. Let's see what
the buildfarm thinks.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company