| Lists: | pgsql-hackers |
|---|
| From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | pg_prewarm really needs some CHECK_FOR_INTERRUPTS |
| Date: | 2014-11-11 11:17:11 |
| Message-ID: | 20141111111711.GF22216@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Hi,
pg_prewarm() currently can't be cannot be interrupted - which seems odd
given that it's intended to read large amounts of data from disk. A
rather slow process.
Unless somebody protests I'm going to add a check to the top of each of
the three loops.
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_prewarm really needs some CHECK_FOR_INTERRUPTS |
| Date: | 2014-11-11 12:11:02 |
| Message-ID: | CAB7nPqTdzggRbJv_cXOOXN_61t3ZKj_DOVRUw7+q83ak3JjNmA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Tue, Nov 11, 2014 at 8:17 PM, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
> pg_prewarm() currently can't be cannot be interrupted - which seems odd
> given that it's intended to read large amounts of data from disk. A
> rather slow process.
>
> Unless somebody protests I'm going to add a check to the top of each of
> the three loops.
Good idea, +1.
--
Michael
| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_prewarm really needs some CHECK_FOR_INTERRUPTS |
| Date: | 2014-11-11 13:11:48 |
| Message-ID: | CA+TgmoZ5YfmGzO_HrYmh5oG1MioyKb57dd_vV=G4Nx8vsuf4=w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Tue, Nov 11, 2014 at 6:17 AM, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
> pg_prewarm() currently can't be cannot be interrupted - which seems odd
> given that it's intended to read large amounts of data from disk. A
> rather slow process.
Oops.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: pg_prewarm really needs some CHECK_FOR_INTERRUPTS |
| Date: | 2014-11-12 20:29:35 |
| Message-ID: | 20141112202935.GF13473@awork2.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On 2014-11-11 12:17:11 +0100, Andres Freund wrote:
> pg_prewarm() currently can't be cannot be interrupted - which seems odd
> given that it's intended to read large amounts of data from disk. A
> rather slow process.
>
> Unless somebody protests I'm going to add a check to the top of each of
> the three loops.
Pushed to master and 9.4.
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services