| Lists: | pgsql-hackers |
|---|
| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Nitpicky doc corrections for BRIN functions of pageinspect |
| Date: | 2014-11-20 04:02:59 |
| Message-ID: | CAB7nPqSpKoKqenq61yV2frxP_5p32vBx_mQK1UNk04cZVjz4+w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Hi all,
Just a small thing I noticed while looking at pageinspect.sgml, the
set of SQL examples related to BRIN indexes uses lower-case characters
for reserved keywords. This has been introduced by 7516f52.
Patch is attached.
Regards,
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| 20141120_pageinspect_brin_case.patch | application/x-patch | 2.2 KB |
| From: | Peter Geoghegan <pg(at)heroku(dot)com> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Nitpicky doc corrections for BRIN functions of pageinspect |
| Date: | 2014-11-20 04:08:18 |
| Message-ID: | CAM3SWZQqaqgSMgyiFkEqPfp9gaXD7AnTrAwd5YGicoi4i8A7TQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Wed, Nov 19, 2014 at 8:02 PM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> Just a small thing I noticed while looking at pageinspect.sgml, the
> set of SQL examples related to BRIN indexes uses lower-case characters
> for reserved keywords. This has been introduced by 7516f52.
> Patch is attached.
My nitpicky observation about pageinspect + BRIN was that the comments
added to the pageinspect SQL file for the SQL-callable function
brin_revmap_data() have a comment header style slightly inconsistent
with the existing items.
--
Peter Geoghegan
| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Peter Geoghegan <pg(at)heroku(dot)com> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Nitpicky doc corrections for BRIN functions of pageinspect |
| Date: | 2014-12-02 15:23:04 |
| Message-ID: | 20141202152304.GM1737@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Peter Geoghegan wrote:
> On Wed, Nov 19, 2014 at 8:02 PM, Michael Paquier
> <michael(dot)paquier(at)gmail(dot)com> wrote:
> > Just a small thing I noticed while looking at pageinspect.sgml, the
> > set of SQL examples related to BRIN indexes uses lower-case characters
> > for reserved keywords. This has been introduced by 7516f52.
> > Patch is attached.
>
> My nitpicky observation about pageinspect + BRIN was that the comments
> added to the pageinspect SQL file for the SQL-callable function
> brin_revmap_data() have a comment header style slightly inconsistent
> with the existing items.
Pushed.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Peter Geoghegan <pg(at)heroku(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Nitpicky doc corrections for BRIN functions of pageinspect |
| Date: | 2014-12-02 23:27:32 |
| Message-ID: | CAB7nPqQBWGGHW3cA8MLfQ30w-uE9925xjzewCZZwmPBXevRPeA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Wed, Dec 3, 2014 at 12:23 AM, Alvaro Herrera
<alvherre(at)2ndquadrant(dot)com> wrote:
> Peter Geoghegan wrote:
>> On Wed, Nov 19, 2014 at 8:02 PM, Michael Paquier
>> <michael(dot)paquier(at)gmail(dot)com> wrote:
>> > Just a small thing I noticed while looking at pageinspect.sgml, the
>> > set of SQL examples related to BRIN indexes uses lower-case characters
>> > for reserved keywords. This has been introduced by 7516f52.
>> > Patch is attached.
>>
>> My nitpicky observation about pageinspect + BRIN was that the comments
>> added to the pageinspect SQL file for the SQL-callable function
>> brin_revmap_data() have a comment header style slightly inconsistent
>> with the existing items.
>
> Pushed.
Thanks.
--
Michael