| Lists: | pgsql-bugs |
|---|
| From: | lizenko79(at)gmail(dot)com |
|---|---|
| To: | pgsql-bugs(at)postgresql(dot)org |
| Subject: | BUG #12024: autocomplete doesn't work for ALTER CONSTRAINT |
| Date: | 2014-11-21 15:19:57 |
| Message-ID: | 20141121151957.15514.43804@wrigleys.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-bugs |
The following bug has been logged on the website:
Bug reference: 12024
Logged by: Andrey Lizenko
Email address: lizenko79(at)gmail(dot)com
PostgreSQL version: 9.4beta2
Operating system: Ubuntu LTS 12.04
Description:
Its a very minor bug in psql client.
Server and client version is 9.4 RC (cann't see rc, only beta in version
ашудв)
If I try to press "tab" to complete
ALTER TABLE <some_table> ALTER CO...
only COLUMN hint is shown, CONSTRAINT is missing
Full command works fine.
postgres=# ALTER TABLE b ALTER CONSTRAINT "b_cons" DEFERRABLE INITIALLY
DEFERRED;
ALTER TABLE
| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | lizenko79(at)gmail(dot)com |
| Cc: | pgsql-bugs(at)postgresql(dot)org |
| Subject: | Re: BUG #12024: autocomplete doesn't work for ALTER CONSTRAINT |
| Date: | 2014-11-26 05:54:50 |
| Message-ID: | CAB7nPqSg53+PbDa89DDUHeAhroqrL7Gsy3cy5qeNqdm5cOkViA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-bugs |
On Sat, Nov 22, 2014 at 12:19 AM, <lizenko79(at)gmail(dot)com> wrote:
> If I try to press "tab" to complete
> ALTER TABLE <some_table> ALTER CO...
>
> only COLUMN hint is shown, CONSTRAINT is missing
>
Yes, indeed. Supporting ALTER TABLE <foo> ALTER CONSTRAINT has proved not
to be that complicated. Per se the patch attached. I haven't added the part
about deferred constraints but still that's an improvement as it can go up
to the constraint detection.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| 20141126_constraint_tabcompl.patch | text/x-patch | 1.7 KB |
| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | lizenko79(at)gmail(dot)com, pgsql-bugs <pgsql-bugs(at)postgresql(dot)org> |
| Subject: | Re: BUG #12024: autocomplete doesn't work for ALTER CONSTRAINT |
| Date: | 2014-11-28 12:31:20 |
| Message-ID: | CAHGQGwF8iuPt7XirP7Gpb4y7UM48h23FQij3SPPMKC=G2wzEXg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-bugs |
On Wed, Nov 26, 2014 at 2:54 PM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> On Sat, Nov 22, 2014 at 12:19 AM, <lizenko79(at)gmail(dot)com> wrote:
>>
>> If I try to press "tab" to complete
>> ALTER TABLE <some_table> ALTER CO...
>>
>> only COLUMN hint is shown, CONSTRAINT is missing
>
> Yes, indeed. Supporting ALTER TABLE <foo> ALTER CONSTRAINT has proved not to
> be that complicated. Per se the patch attached.
Pushed. Thanks!
Regards,
--
Fujii Masao