Re: pgsql: Oops, I fumbled the backpatch of pg_upgrade changes.

Lists: pgsql-committers
From: Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Oops, I fumbled the backpatch of pg_upgrade changes.
Date: 2014-10-25 18:00:23
Message-ID: E1Xi5dX-00017a-Cb@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers

Oops, I fumbled the backpatch of pg_upgrade changes.

Somehow I got 9.2 and 9.4 correct, but fumbled 9.3.

Branch
------
REL9_3_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/9945f4e0f546f2e53b430fba32831ae6c73abb78

Modified Files
--------------
contrib/pg_upgrade/check.c | 15 +++++++++------
1 file changed, 9 insertions(+), 6 deletions(-)

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Oops, I fumbled the backpatch of pg_upgrade changes.
Date: 2014-11-01 13:22:08
Message-ID: 5454DE80.4010205@gmx.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers

On 10/25/14 2:00 PM, Heikki Linnakangas wrote:
> Oops, I fumbled the backpatch of pg_upgrade changes.
>
> Somehow I got 9.2 and 9.4 correct, but fumbled 9.3.

This is still producing a compiler warning:

check.c:471:2: error: implicit declaration of function
'pg_valid_server_encoding' [-Werror=implicit-function-declaration]

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Oops, I fumbled the backpatch of pg_upgrade changes.
Date: 2014-11-01 13:36:39
Message-ID: CAB7nPqS3Zgpjfk7pF8XZw2jnMdGUtAwOpShaMX7XChWg7cKa=A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers

On Sat, Nov 1, 2014 at 10:22 PM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:

> On 10/25/14 2:00 PM, Heikki Linnakangas wrote:
> > Oops, I fumbled the backpatch of pg_upgrade changes.
> >
> > Somehow I got 9.2 and 9.4 correct, but fumbled 9.3.
>
> This is still producing a compiler warning:
>
> check.c:471:2: error: implicit declaration of function
> 'pg_valid_server_encoding' [-Werror=implicit-function-declaration]
>
check.c is missing an inclusion of mb/pg_wchar.h on 9.3 only.
--
Michael

Attachment Content-Type Size
20141101_pg_upgrade_fix_warning,patch application/octet-stream 266 bytes
From: Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: Oops, I fumbled the backpatch of pg_upgrade changes.
Date: 2014-11-03 17:31:47
Message-ID: 5457BC03.5060804@vmware.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers

On 11/01/2014 03:36 PM, Michael Paquier wrote:
> On Sat, Nov 1, 2014 at 10:22 PM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
>
>> On 10/25/14 2:00 PM, Heikki Linnakangas wrote:
>>> Oops, I fumbled the backpatch of pg_upgrade changes.
>>>
>>> Somehow I got 9.2 and 9.4 correct, but fumbled 9.3.
>>
>> This is still producing a compiler warning:
>>
>> check.c:471:2: error: implicit declaration of function
>> 'pg_valid_server_encoding' [-Werror=implicit-function-declaration]
>>
> check.c is missing an inclusion of mb/pg_wchar.h on 9.3 only.

Thanks, fixed.

- Heikki