Lists: | pgsql-hackers |
---|
From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
---|---|
To: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Missing newlines in verbose logs of pg_dump, introduced by RLS patch |
Date: | 2014-09-28 04:36:51 |
Message-ID: | CAB7nPqRV0ac4gsy1ojOjeEPJaNeUnqnFiyGQFAAPVLQowy8yLA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-hackers |
Hi all,
Recent commit 491c029 introducing RLS has broken a bit the verbose logs of
pg_dump, one message missing a newline:
+ if (g_verbose)
+ write_msg(NULL, "reading row-security enabled for
table \"%s\"",
+ tbinfo->dobj.name);
The patch attached corrects that.
Regards,
--
Michael
Attachment | Content-Type | Size |
---|---|---|
20140928_rls_pgdump_fix.patch | application/octet-stream | 459 bytes |
From: | Fabrízio de Royes Mello <fabriziomello(at)gmail(dot)com> |
---|---|
To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
Cc: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Missing newlines in verbose logs of pg_dump, introduced by RLS patch |
Date: | 2014-09-29 01:07:11 |
Message-ID: | CAFcNs+rGyY7xuQzHTdjP2nk=BkaCA2gtgtV7vv94B6GkEAq0Hw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-hackers |
On Sun, Sep 28, 2014 at 1:36 AM, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
wrote:
>
> Hi all,
>
> Recent commit 491c029 introducing RLS has broken a bit the verbose logs
of pg_dump, one message missing a newline:
> + if (g_verbose)
> + write_msg(NULL, "reading row-security enabled for
table \"%s\"",
> + tbinfo->dobj.name);
> The patch attached corrects that.
>
The schema name is missing... attached patch add it.
Regards,
--
Fabrízio de Royes Mello
Consultoria/Coaching PostgreSQL
>> Timbira: http://www.timbira.com.br
>> Blog: http://fabriziomello.github.io
>> Linkedin: http://br.linkedin.com/in/fabriziomello
>> Twitter: http://twitter.com/fabriziomello
>> Github: http://github.com/fabriziomello
Attachment | Content-Type | Size |
---|---|---|
pgdump_verbose_msg_fix_v1.patch | text/x-diff | 1022 bytes |
From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
---|---|
To: | Fabrízio Mello <fabriziomello(at)gmail(dot)com> |
Cc: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Missing newlines in verbose logs of pg_dump, introduced by RLS patch |
Date: | 2014-09-29 01:23:31 |
Message-ID: | CAB7nPqT3cyETOp35umOvnbnxu23tpAo80CgFPw2r-Zg2T3C4ng@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-hackers |
On Mon, Sep 29, 2014 at 10:07 AM, Fabrízio de Royes Mello <
fabriziomello(at)gmail(dot)com> wrote:
> The schema name is missing... attached patch add it.
>
Ah, right, thanks. It didn't occur to me immediately :) Your patch looks
good to me, and you are updating as well the second message that missed the
schema name in getRowSecurity.
Regards,
--
Michael
From: | Stephen Frost <sfrost(at)snowman(dot)net> |
---|---|
To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
Cc: | Fabrízio Mello <fabriziomello(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Missing newlines in verbose logs of pg_dump, introduced by RLS patch |
Date: | 2014-09-29 13:09:00 |
Message-ID: | 20140929130900.GQ16422@tamriel.snowman.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-hackers |
* Michael Paquier (michael(dot)paquier(at)gmail(dot)com) wrote:
> On Mon, Sep 29, 2014 at 10:07 AM, Fabrízio de Royes Mello <
> fabriziomello(at)gmail(dot)com> wrote:
>
> > The schema name is missing... attached patch add it.
> >
> Ah, right, thanks. It didn't occur to me immediately :) Your patch looks
> good to me, and you are updating as well the second message that missed the
> schema name in getRowSecurity.
Thanks to you both- will review.
Thanks again,
Stephen
From: | Stephen Frost <sfrost(at)snowman(dot)net> |
---|---|
To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
Cc: | Fabrízio Mello <fabriziomello(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Missing newlines in verbose logs of pg_dump, introduced by RLS patch |
Date: | 2014-10-03 20:36:45 |
Message-ID: | 20141003203645.GV28859@tamriel.snowman.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-hackers |
* Stephen Frost (sfrost(at)snowman(dot)net) wrote:
> * Michael Paquier (michael(dot)paquier(at)gmail(dot)com) wrote:
> > On Mon, Sep 29, 2014 at 10:07 AM, Fabrízio de Royes Mello <
> > fabriziomello(at)gmail(dot)com> wrote:
> >
> > > The schema name is missing... attached patch add it.
> > >
> > Ah, right, thanks. It didn't occur to me immediately :) Your patch looks
> > good to me, and you are updating as well the second message that missed the
> > schema name in getRowSecurity.
>
> Thanks to you both- will review.
Fix pushed- thanks!
Stephen