Missing comment block at the top of streamutil.h and receivelog.h

Hi all,

As mentioned in $subject, the header files in src/bin/pg_basebackup do
not have a comment block at the top and do not have any copyright
text.
Any reason for that? Shouldn't we have something for consistency with
the other files like in the patch attached?

Regards,
--
Michael

On Sat, Aug 23, 2014 at 11:59 PM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> As mentioned in $subject, the header files in src/bin/pg_basebackup do
> not have a comment block at the top and do not have any copyright
> text.
> Any reason for that? Shouldn't we have something for consistency with
> the other files like in the patch attached?

Probably that's a good idea, but do we really need Author: tags? I
know we have those in a few places, but certainly not everywhere, and
as time goes by they tend to be less accurate reflections of who wrote
the latest code (as opposed to the original code). Furthermore, every
time we include them, it tends to increase the demand to add even more
of them because, hey, everybody likes to be acknowledged.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Tue, Aug 26, 2014 at 11:03 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Sat, Aug 23, 2014 at 11:59 PM, Michael Paquier
> <michael(dot)paquier(at)gmail(dot)com> wrote:
>> As mentioned in $subject, the header files in src/bin/pg_basebackup do
>> not have a comment block at the top and do not have any copyright
>> text.
>> Any reason for that? Shouldn't we have something for consistency with
>> the other files like in the patch attached?
>
> Probably that's a good idea, but do we really need Author: tags? I
> know we have those in a few places, but certainly not everywhere, and
> as time goes by they tend to be less accurate reflections of who wrote
> the latest code (as opposed to the original code). Furthermore, every
> time we include them, it tends to increase the demand to add even more
> of them because, hey, everybody likes to be acknowledged.

Given that I'm the one named in it - nah, just drop it.

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/

On Wed, Aug 27, 2014 at 6:10 AM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
> On Tue, Aug 26, 2014 at 11:03 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> Probably that's a good idea, but do we really need Author: tags? I
>> know we have those in a few places, but certainly not everywhere, and
>> as time goes by they tend to be less accurate reflections of who wrote
>> the latest code (as opposed to the original code). Furthermore, every
>> time we include them, it tends to increase the demand to add even more
>> of them because, hey, everybody likes to be acknowledged.
>
> Given that I'm the one named in it - nah, just drop it.
Updated patch updated without any Author tag. Perhaps you want to drop
it in all the *.c files in src/bin/pg_basebackup?
Regards,
--
Michael

On Wed, Aug 27, 2014 at 10:34 AM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> On Wed, Aug 27, 2014 at 6:10 AM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
>> On Tue, Aug 26, 2014 at 11:03 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>>> Probably that's a good idea, but do we really need Author: tags? I
>>> know we have those in a few places, but certainly not everywhere, and
>>> as time goes by they tend to be less accurate reflections of who wrote
>>> the latest code (as opposed to the original code). Furthermore, every
>>> time we include them, it tends to increase the demand to add even more
>>> of them because, hey, everybody likes to be acknowledged.
>>
>> Given that I'm the one named in it - nah, just drop it.
> Updated patch updated without any Author tag.

I think that it's better to add an include guard like

#ifndef RECEIVELOG_H
#define RECEIVELOG_H
...
#endif

Regards,

--
Fujii Masao

On Wed, Aug 27, 2014 at 12:31 PM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> On Wed, Aug 27, 2014 at 10:34 AM, Michael Paquier
> <michael(dot)paquier(at)gmail(dot)com> wrote:
> I think that it's better to add an include guard like
>
> #ifndef RECEIVELOG_H
> #define RECEIVELOG_H
> ...
> #endif
Oh indeed, that was missing as well! Please see attached.
--
Michael

On Wed, Aug 27, 2014 at 2:07 PM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> On Wed, Aug 27, 2014 at 12:31 PM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>> On Wed, Aug 27, 2014 at 10:34 AM, Michael Paquier
>> <michael(dot)paquier(at)gmail(dot)com> wrote:
>> I think that it's better to add an include guard like
>>
>> #ifndef RECEIVELOG_H
>> #define RECEIVELOG_H
>> ...
>> #endif
> Oh indeed, that was missing as well! Please see attached.

Thanks! Applied.

Regards,

--
Fujii Masao