[PATCH] pg_dump: Sort overloaded functions in deterministic order

Lists: pgsql-hackers
From: Joel Jacobson <joel(at)trustly(dot)com>
To: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: [PATCH] pg_dump: Sort overloaded functions in deterministic order
Date: 2012-07-19 15:47:35
Message-ID: CAASwCXdCCw=1mzxSN2+V41V+i6nYpvU9TRhZ7Skx=Cev18YuTg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Makes pg_dump sort overloaded functions in deterministic order.

The field "proiargs" has been added to FuncInfo and is set by getFuncs()
and getAggregates() for all functions and aggregates.

DOTypeNameCompare uses this field to break ties if the name and number of
arguments are the same. This avoid having to default to OID sorting.

This patch is independent from the ongoing discussion of the pg_dump --split
option. Even if we can't agree on how to do the splitting of objects into
files, it still makes sense to fix the sort order of overloaded functions.

Attachment Content-Type Size
pg_dump_deterministic_order_v4.patch application/octet-stream 6.2 KB
pg_dump_deterministic_order.t application/x-troff 1.2 KB