| Lists: | pgsql-hackers |
|---|
| From: | Phil Sorber <phil(at)omniti(dot)com> |
|---|---|
| To: | PostgreSQL-development Hackers <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | [PATCH] PQping Docs |
| Date: | 2013-01-21 18:45:55 |
| Message-ID: | CADAkt-jBpbfex6POB-cD=HrCp5NWfwKRfz8VTxrHcphj3Z7j6A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Attached is a patch that adds a note about the FATAL messages that
appear in the logs if you don't pass a valid user or dbname to PQping
or PQpingParams.
This was requested in the pg_isready thread.
| Attachment | Content-Type | Size |
|---|---|---|
| libpq_pqping_doc.diff | application/octet-stream | 763 bytes |
| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Phil Sorber <phil(at)omniti(dot)com> |
| Cc: | PostgreSQL-development Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] PQping Docs |
| Date: | 2013-01-23 15:37:23 |
| Message-ID: | CA+TgmobhkBKMwtan4EabAsdoE4cx8Ag3d4428Zzk3pkri=9A=w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Mon, Jan 21, 2013 at 1:45 PM, Phil Sorber <phil(at)omniti(dot)com> wrote:
> Attached is a patch that adds a note about the FATAL messages that
> appear in the logs if you don't pass a valid user or dbname to PQping
> or PQpingParams.
>
> This was requested in the pg_isready thread.
Can I counter-propose the attached, which puts the relevant text
closer to the scene of the crime?
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| Attachment | Content-Type | Size |
|---|---|---|
| libpq_ping_doc_rmh.patch | application/octet-stream | 1.5 KB |
| From: | Phil Sorber <phil(at)omniti(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | PostgreSQL-development Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] PQping Docs |
| Date: | 2013-01-23 15:59:14 |
| Message-ID: | CADAkt-jHqG753DTRLVGvZZRgid3=MF+pNH+7LpPRCR2CmbHXfg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Wed, Jan 23, 2013 at 10:37 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Mon, Jan 21, 2013 at 1:45 PM, Phil Sorber <phil(at)omniti(dot)com> wrote:
>> Attached is a patch that adds a note about the FATAL messages that
>> appear in the logs if you don't pass a valid user or dbname to PQping
>> or PQpingParams.
>>
>> This was requested in the pg_isready thread.
>
> Can I counter-propose the attached, which puts the relevant text
> closer to the scene of the crime?
>
This seems reasonable to me.
> --
> Robert Haas
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Phil Sorber <phil(at)omniti(dot)com> |
| Cc: | PostgreSQL-development Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] PQping Docs |
| Date: | 2013-01-23 16:06:02 |
| Message-ID: | CA+TgmoZqk3vtNE7+-+WhamVV3vy_HvWf3rHMR7_hzPzJRmEKmg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Wed, Jan 23, 2013 at 10:59 AM, Phil Sorber <phil(at)omniti(dot)com> wrote:
> On Wed, Jan 23, 2013 at 10:37 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> On Mon, Jan 21, 2013 at 1:45 PM, Phil Sorber <phil(at)omniti(dot)com> wrote:
>>> Attached is a patch that adds a note about the FATAL messages that
>>> appear in the logs if you don't pass a valid user or dbname to PQping
>>> or PQpingParams.
>>>
>>> This was requested in the pg_isready thread.
>>
>> Can I counter-propose the attached, which puts the relevant text
>> closer to the scene of the crime?
>>
> This seems reasonable to me.
OK, done.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company