| Lists: | pgsql-hackers |
|---|
| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Warning in views.c |
| Date: | 2012-01-16 20:47:49 |
| Message-ID: | CABUevEzCDzNztyTjDACiYJrmEV0Y9xYFp4rbM7x2CCbuinvzhg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Seem 1575fbcb caused this warning:
view.c: In function ‘DefineVirtualRelation’:
view.c:105:6: warning: variable ‘namespaceId’ set but not used
[-Wunused-but-set-variable]
Attached seems to be the easy fix - or am I missing something obvious?
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
| Attachment | Content-Type | Size |
|---|---|---|
| command_view_warning.patch | text/x-patch | 797 bytes |
| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Warning in views.c |
| Date: | 2012-01-19 20:43:18 |
| Message-ID: | CA+TgmoZhZMKmuxQni3JYEZT-jEHxbzNxgg_KQ_i6AAsi9c7ADg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Mon, Jan 16, 2012 at 3:47 PM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
> Seem 1575fbcb caused this warning:
>
> view.c: In function ‘DefineVirtualRelation’:
> view.c:105:6: warning: variable ‘namespaceId’ set but not used
> [-Wunused-but-set-variable]
>
> Attached seems to be the easy fix - or am I missing something obvious?
No, I think you nailed it. There is some more refactoring that should
be done there, I think, but until it is, we don't need that return
value for anything...
Thanks for fixing it.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company