| Lists: | pgsql-hackers |
|---|
| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | pg_upgrade misreports full disk |
| Date: | 2013-11-13 15:28:22 |
| Message-ID: | 52839A96.8030809@gmx.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
When pg_upgrade encounters a full disk while copying relation files,
it reports this as:
error while copying relation "xyz" (...): Success
because it doesn't set errno in some error cases. In other places we
treat short writes as ENOSPC, so here is a patch to do that for
pg_upgrade as well.
| Attachment | Content-Type | Size |
|---|---|---|
| pg_upgrade-fix.patch | text/x-diff | 867 bytes |
| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_upgrade misreports full disk |
| Date: | 2013-11-15 13:47:35 |
| Message-ID: | CA+TgmoYw=+9atfFVhi5e0bb55GWbHmQux3FvSaYxpPLRo3VLXQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Wed, Nov 13, 2013 at 10:28 AM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
> When pg_upgrade encounters a full disk while copying relation files,
> it reports this as:
>
> error while copying relation "xyz" (...): Success
>
> because it doesn't set errno in some error cases. In other places we
> treat short writes as ENOSPC, so here is a patch to do that for
> pg_upgrade as well.
+1 for committing this and back-patching it.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company