| Lists: | pgsql-hackers |
|---|
| From: | Craig Ringer <craig(at)2ndquadrant(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | [PATCH] Improve bytea error messages |
| Date: | 2014-07-06 08:17:55 |
| Message-ID: | 53B90633.8030605@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Hi all
After someone reported somewhat less than informative errors in bytea
decoding (http://stackoverflow.com/q/24588866/398670) I thought I'd put
together a quick patch to improve the errors here.
Please merge.
--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Improve-bytea-decoding-error-messages.patch | text/x-patch | 1.4 KB |
| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Craig Ringer <craig(at)2ndquadrant(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Improve bytea error messages |
| Date: | 2014-07-07 23:44:53 |
| Message-ID: | CA+TgmoYZg24E7B_xHxQQZoi23xipjH+nU-HK7wC3eh4E0h46zQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Sun, Jul 6, 2014 at 4:17 AM, Craig Ringer <craig(at)2ndquadrant(dot)com> wrote:
> After someone reported somewhat less than informative errors in bytea
> decoding (http://stackoverflow.com/q/24588866/398670) I thought I'd put
> together a quick patch to improve the errors here.
The first two changes seem fine from here, but I think the use of
parentheses in the third one likely violates our message style
guidelines.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From: | Craig Ringer <craig(at)2ndquadrant(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Improve bytea error messages |
| Date: | 2014-07-08 04:49:56 |
| Message-ID: | 53BB7874.3020204@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On 07/08/2014 07:44 AM, Robert Haas wrote:
> On Sun, Jul 6, 2014 at 4:17 AM, Craig Ringer <craig(at)2ndquadrant(dot)com> wrote:
>> After someone reported somewhat less than informative errors in bytea
>> decoding (http://stackoverflow.com/q/24588866/398670) I thought I'd put
>> together a quick patch to improve the errors here.
>
> The first two changes seem fine from here, but I think the use of
> parentheses in the third one likely violates our message style
> guidelines.
Good point.
Better?
Putting it in ERRHINT is more appropriate.
--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Improve-bytea-decoding-error-messages.patch | text/x-patch | 1.4 KB |
| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Craig Ringer <craig(at)2ndquadrant(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Improve bytea error messages |
| Date: | 2014-07-09 15:05:49 |
| Message-ID: | CA+TgmoauwBR3mxKq3C7z+4dPjSQj1y9Pw8eikGP0mrxSk7vJzQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Tue, Jul 8, 2014 at 12:49 AM, Craig Ringer <craig(at)2ndquadrant(dot)com> wrote:
> On 07/08/2014 07:44 AM, Robert Haas wrote:
>> On Sun, Jul 6, 2014 at 4:17 AM, Craig Ringer <craig(at)2ndquadrant(dot)com> wrote:
>>> After someone reported somewhat less than informative errors in bytea
>>> decoding (http://stackoverflow.com/q/24588866/398670) I thought I'd put
>>> together a quick patch to improve the errors here.
>>
>> The first two changes seem fine from here, but I think the use of
>> parentheses in the third one likely violates our message style
>> guidelines.
>
> Good point.
>
> Better?
>
> Putting it in ERRHINT is more appropriate.
Looks OK to me. Committed.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company