| Lists: | pgsql-hackers |
|---|
| From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Cc: | Amit Khandekar <amit(dot)khandekar(at)enterprisedb(dot)com>, rajeev(dot)rastogi(at)huawei(dot)com |
| Subject: | review: psql command copy count tag |
| Date: | 2014-01-29 20:26:43 |
| Message-ID: | CAFj8pRDupm6qhzWOmPyAgzN4Bse3SL+wTGSQHBvoSypz9yRW9g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Hello
1. I had to rebase this patch - actualised version is attached - I merged
two patches to one
2. The psql code is compiled without issues after patching
3. All regress tests are passed without errors
5. We like this feature - it shows interesting info without any slowdown -
psql copy command is more consistent with server side copy statement from
psql perspective.
This patch is ready for commit
Regards
Pavel
| Attachment | Content-Type | Size |
|---|---|---|
| psql_copy_count_tag-2014-01-29-1.patch | text/x-patch | 8.7 KB |
| From: | Rajeev rastogi <rajeev(dot)rastogi(at)huawei(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Cc: | Amit Khandekar <amit(dot)khandekar(at)enterprisedb(dot)com>, "pavel(dot)stehule(at)gmail(dot)com" <pavel(dot)stehule(at)gmail(dot)com> |
| Subject: | Re: review: psql command copy count tag |
| Date: | 2014-03-10 04:15:09 |
| Message-ID: | BF2827DCCE55594C8D7A8F7FFD3AB7713DDD42E6@SZXEML508-MBX.china.huawei.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
As mentioned by Pavel also, this patch will be very useful, which provides below enhancement:
1. Brings consistency between copy from “stdin” and “file”.
2. Consistent with server side copy statement.
3. Also fixes the issue related to “\copy destination file becomes default destination file for next command given in sequence”.
This has been in “Ready for committer” stage for long time.
Please check if this can be committed now or any other changes required.
Thanks and Regards,
Kumar Rajeev Rastogi
------------------------------------------------------------------------------------------------------------------------------
This e-mail and its attachments contain confidential information from HUAWEI, which
is intended only for the person or entity whose address is listed above. Any use of the
information contained herein in any way (including, but not limited to, total or partial
disclosure, reproduction, or dissemination) by persons other than the intended
recipient(s) is prohibited. If you receive this e-mail in error, please notify the sender by
phone or email immediately and delete it!
From: Pavel Stehule [mailto:pavel(dot)stehule(at)gmail(dot)com]
Sent: 30 January 2014 01:57
To: PostgreSQL Hackers
Cc: Amit Khandekar; Rajeev rastogi
Subject: review: psql command copy count tag
related to http://www.postgresql.org/message-id/BF2827DCCE55594C8D7A8F7FFD3AB7713DDB15F8@SZXEML508-MBX.china.huawei.com
Hello
1. I had to rebase this patch - actualised version is attached - I merged two patches to one
2. The psql code is compiled without issues after patching
3. All regress tests are passed without errors
5. We like this feature - it shows interesting info without any slowdown - psql copy command is more consistent with server side copy statement from psql perspective.
This patch is ready for commit
Regards
Pavel
| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Rajeev rastogi <rajeev(dot)rastogi(at)huawei(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Amit Khandekar <amit(dot)khandekar(at)enterprisedb(dot)com>, "pavel(dot)stehule(at)gmail(dot)com" <pavel(dot)stehule(at)gmail(dot)com> |
| Subject: | Re: review: psql command copy count tag |
| Date: | 2014-03-10 04:37:10 |
| Message-ID: | 7001.1394426230@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Rajeev rastogi <rajeev(dot)rastogi(at)huawei(dot)com> writes:
> This has been in Ready for committer stage for long time.
Yeah, I started to work on it and got distracted, but was working on it
some more yesterday. As submitted, it leaks PGresults, and makes some
inconsistent and mostly undocumented changes in the APIs of the psql
functions involved. But I'm pretty close to having something committable.
regards, tom lane