Re: small bug in to_char and TM prefix, in RC

>
>It's pretty much guaranteed not to work on multibyte characters,
>regardless of platform :-(. This did not matter for non-localized
>month/day names, but it does matter now.
>
>In the context of the existing code, the simplest solution would be
>to provide separate translations of "SUNDAY", "Sunday", "sunday" etc
>but this will not work for the planned strftime() change.
>

and what use modified pg_tolower only for TM fields? Like:

if (S_TM(suf))
{
strcpy(inout, localize_month(tm->tm_mon - 1));
str_towupper(inout);
}
else
{
strcpy(inout, months[tm->tm_mon - 1]);
str_toupper(inout);
}

regards

Pavel Stehule

_________________________________________________________________
Chcete sdilet sve obrazky a hudbu s prateli? http://messenger.msn.cz/

"Pavel Stehule" <pavel(dot)stehule(at)hotmail(dot)com> writes:
> str_towupper(inout);

Since this wouldn't be a length-preserving change, it seems a bit scary
to invent a function defined as above. (The whole question of buffer
overflow in to_char needs to be looked at anyway, probably.)

regards, tom lane