Re: Update functions and trigger functions by clicking

Lists: pgadmin-hackers
From: Vinicius Santos <vinicius(dot)santos(dot)lista(at)gmail(dot)com>
To: pgadmin-hackers(at)postgresql(dot)org
Subject: Re: Update functions and trigger functions by clicking
Date: 2011-06-04 19:05:28
Message-ID: 4DEA81F8.2060603@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgadmin-hackers


Hi, sorry for the delay in responding.

I agree to share with you.

First, the update will be different for "F5 refresh" and per "click
refresh". This could confuse people.

Second, this does not obviate the problem of another user to create, for
example, a table and this table does not appear to me.

In other words, I think my Schema is completely updated, when in fact it
is not.

What do you think?

Again, I do not know the translation is perfect.


From: Dave Page <dpage(at)pgadmin(dot)org>
To: Vinicius Santos <vinicius(dot)santos(dot)lista(at)gmail(dot)com>
Cc: pgadmin-hackers(at)postgresql(dot)org
Subject: Re: Update functions and trigger functions by clicking
Date: 2011-06-06 08:19:14
Message-ID: BANLkTimvqBr7mpVgdsSFU5EtSxFRhpsbZA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgadmin-hackers

On Sat, Jun 4, 2011 at 8:05 PM, Vinicius Santos
<vinicius(dot)santos(dot)lista(at)gmail(dot)com> wrote:
>
> Hi, sorry for the delay in responding.
>
> I agree to share with you.
>
> First, the update will be different for "F5 refresh" and per "click
> refresh". This could confuse people.

I don't think so - there's a pretty obvious difference between
refreshing the tree on selection of a menu option or button click, and
simply refreshing the object that's selected.

> Second, this does not obviate the problem of another user to create, for
> example, a table and this table does not appear to me.

No. it doesn't.

> In other words, I think my Schema is completely updated, when in fact it
> is not.
>
> What do you think?

Updating the entire schema (it may well be that much, if everything is
expanded) is going to be far too expensive on anything but the
smallest database on a very fast machine. We have users with schemas
ranging from a handful to tens or even hundreds of thousands of
objects - for most them, refreshing a whole schema hierarchy on every
click is not an option.

I'd probably be happy with a patch that offered *both* "refresh object
on click" and "refresh object and children on click", but not just the
latter - the use case is just too narrow imho.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


From: Vinicius Santos <vinicius(dot)santos(dot)lista(at)gmail(dot)com>
To: pgadmin-hackers(at)postgresql(dot)org
Subject: Re: Update functions and trigger functions by clicking
Date: 2011-06-07 00:51:44
Message-ID: BANLkTiniLaZzd72dPwJCv6m3PbjsYxvZfA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgadmin-hackers

>
>
> I'd probably be happy with a patch that offered *both* "refresh object
> on click" and "refresh object and children on click", but not just the
> latter - the use case is just too narrow imho.
>
>
I agree with you.

What do you think of a ComboBox with the two options?

I'll start to develop, and sending the patch in a few weeks, so you take a
look.

Thanks.


From: Dave Page <dpage(at)pgadmin(dot)org>
To: Vinicius Santos <vinicius(dot)santos(dot)lista(at)gmail(dot)com>
Cc: pgadmin-hackers(at)postgresql(dot)org
Subject: Re: Update functions and trigger functions by clicking
Date: 2011-06-07 07:00:41
Message-ID: BANLkTikvXcFXthgWfgPGqdS-DzKS5gORvA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgadmin-hackers

On Tue, Jun 7, 2011 at 1:51 AM, Vinicius Santos
<vinicius(dot)santos(dot)lista(at)gmail(dot)com> wrote:
>>
>> I'd probably be happy with a patch that offered *both* "refresh object
>> on click" and "refresh object and children on click", but not just the
>> latter - the use case is just too narrow imho.
>>
>
> I agree with you.
>
> What do you think of a ComboBox with the two options?

Sure. Three options though - don't forget to keep the current
behaviour as an option.

> I'll start to develop, and sending the patch in a few weeks, so you take a
> look.

Thanks!

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company