Re: patches that could use additional reviewers

On Wed, Feb 9, 2011 at 1:35 PM, Stephen Frost <sfrost(at)snowman(dot)net> wrote:
> * Robert Haas (robertmhaas(at)gmail(dot)com) wrote:
>> On Wed, Feb 9, 2011 at 1:09 PM, David E. Wheeler <david(at)kineticode(dot)com> wrote:
>> > Frankly, I think you should surrender some of those 14 and cajole some other folks to take on more.
>>
>> Happily...  only trouble is, I suck at cajoling.  Even my begging is
>> distinctly sub-par.
>>
>> Pleeeeeeeease?
>
> Erm, I've been through the commitfest app a couple of different times,
> but have ignored things which are marked 'Needs Reivew' when there's a
> reviewer listed...
>
> If there are patches where you're marked as the reviewer but you don't
> have time to review them or want help, take your name off as a reviewer
> for them and/or speak up and explicitly ask for help.  I'm not going to
> start reviewing something if I think someone else is already working on
> it..

Of the fourteen I signed up for, 10 are now marked Committed or
Returned with Feedback. Of the remaining four, there are two that
could use more eyes:

MULTISET functions
Change pg_last_xlog_receive_location not to move backwards

A few other ones that could use more reviewers include:

range types
key locks
widen scale factor limit from pgbench

And your patch could probably use another reviewer too, if anyone else
is looking for stuff to help with:

log_csv_fields ; add current_role log option

And there are a few patches with no reviewer at all.

PL/Python invalidate composite argument functions
PL/Python tracebacks
contrib/btree_gist (submitted very late)
SQL/MED - file_fdw

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

* Robert Haas (robertmhaas(at)gmail(dot)com) wrote:
> Of the fourteen I signed up for, 10 are now marked Committed or
> Returned with Feedback. Of the remaining four, there are two that
> could use more eyes:
>
> MULTISET functions

I'll work on this one.

> Change pg_last_xlog_receive_location not to move backwards

I'll take a look at this one too, but I'm not that familiar with the
xlog code, etc, so I'm not sure if I'll be able to comment on
correctness...

> A few other ones that could use more reviewers include:
>
> range types
> key locks

If I can get through the others, I'll try and come back and look at
these.

> widen scale factor limit from pgbench

I was already starting to look at this one, actually. :)

> And your patch could probably use another reviewer too, if anyone else
> is looking for stuff to help with:
>
> log_csv_fields ; add current_role log option

Not sure if it counts if I review it. ;)

> And there are a few patches with no reviewer at all.
>
> PL/Python invalidate composite argument functions
> PL/Python tracebacks

I thought from the other threads that we had someone working the
PL/Pyton patches..? :/

> contrib/btree_gist (submitted very late)

Looks like this one might just be committable w/o additional review, but
if it's still hanging around, I might be able to help.

> SQL/MED - file_fdw

Ditto on this.

Alright, I've marked myself as a reviewer for the ones I'll look at in
the next couple days. The others are up for grabs for others, any
takers on additional reviewers for them?

Thanks,

Stephen

--On 9. Februar 2011 13:45:11 -0500 Robert Haas <robertmhaas(at)gmail(dot)com>
wrote:

> Of the fourteen I signed up for, 10 are now marked Committed or
> Returned with Feedback. Of the remaining four, there are two that
> could use more eyes:

I'd happily jump in and look into one of those, but before mid of next week
i really have no spare time to come up with something :(

--
Thanks

Bernd

[Cc: trimmed]

On Wed, Feb 09, 2011 at 01:45:11PM -0500, Robert Haas wrote:
> A few other ones that could use more reviewers include:

> key locks

I'll take a look at this one.

On Wed, Feb 9, 2011 at 1:45 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> A few other ones that could use more reviewers include:

I've just corrected the status of a few patches in the CommitFest
application. In particular, I set the following back to Needs Review.

SQL/MED - postgresql_fdw
Self-tuning checkpoint sync spread
determining client_encoding from client locale

If anyone can jump in, that would be great.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company