| Lists: | pgsql-hackers |
|---|
| From: | Joseph Adams <joeyadams3(dot)14159(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | patch: Add PGXS support to hstore's Makefile (trivial) |
| Date: | 2011-01-24 02:20:43 |
| Message-ID: | AANLkTinbwrxiGtZ9XEtYA8C79JSujMuD7WUqt=EmbLWp@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
I discovered today that hstore's Makefile currently does not support
PGXS; namely, the ability to install it like so:
USE_PGXS=1 make
sudo USE_PGXS=1 make install
Moreover, hstore is the *only* contrib module whose Makefile does not
contain "PGXS".
The attached patch changes hstore's Makefile so it is like the others.
I have tested the above commands on a copy of the hstore directory
located outside of the PostgreSQL source tree, and it appears to work
just fine. I also tested conventional make and make install, and it
still appears to work as well.
Joey Adams
| Attachment | Content-Type | Size |
|---|---|---|
| hstore-makefile-pgxs.diff | text/x-patch | 925 bytes |
| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Joseph Adams <joeyadams3(dot)14159(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: patch: Add PGXS support to hstore's Makefile (trivial) |
| Date: | 2011-01-24 04:11:09 |
| Message-ID: | AANLkTinpQBZ1cjRFSXSz1nBSZUe=iknbMrb35V-cCqz3@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Sun, Jan 23, 2011 at 9:20 PM, Joseph Adams
<joeyadams3(dot)14159(at)gmail(dot)com> wrote:
> The attached patch changes hstore's Makefile so it is like the others.
Thanks, committed.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From: | Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Joseph Adams <joeyadams3(dot)14159(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: patch: Add PGXS support to hstore's Makefile (trivial) |
| Date: | 2011-01-24 09:16:33 |
| Message-ID: | 87k4hu1x1q.fsf@hi-media-techno.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Sun, Jan 23, 2011 at 9:20 PM, Joseph Adams
> <joeyadams3(dot)14159(at)gmail(dot)com> wrote:
>> The attached patch changes hstore's Makefile so it is like the others.
>
> Thanks, committed.
For the record, I smell bitrot here:
http://archives.postgresql.org/message-id/m21v7jpqe6.fsf@2ndQuadrant.fr
I had included this patch into my extension branch and patch, so this is
a good excuse for me to produce a v27. Will do in a separate thread.
Regards,
--
Dimitri Fontaine
http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support