| Lists: | pgsql-hackers |
|---|
| From: | Kevin Grittner <grimkg(at)gmail(dot)com> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org, Florian Pflug <fgp(at)phlo(dot)org> |
| Subject: | Re: Review: Row-level Locks & SERIALIZABLE transactions, postgres vs. Oracle |
| Date: | 2010-09-18 18:44:48 |
| Message-ID: | AANLkTimvxr1SaR-N6x_Q2gouLp=OttjYdctxn5MUDc-Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
This patch suffered a lot of bitrot in the last month, mostly due to the
noop patch for SSI. It also used the term SERIALIZABLE in many places to
indicate any transaction-snapshot mode transaction, so I applied changes
consistent with the noop patch. I also found a few whitespace and brace
usage issues which seemed to conflict with conventional usage and cleaned
those up. A minor spelling typo also corrected.
A new patch reflecting all this is attached.
This now compiles and passes regression tests. I still need to re-run all
the other tests which Florian and I previously used to test the patch. I
don't have any reason to expect that they will now fail, but one need to be
thorough. Once that is confirmed, I think this will be ready for committer
unless someone can think of something else to throw at it first.
-Kevin
| Attachment | Content-Type | Size |
|---|---|---|
| serializable_row_locks-v2.patch | text/x-diff | 52.9 KB |
| From: | "Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov> |
|---|---|
| To: | "Kevin Grittner" <grimkg(at)gmail(dot)com>, "Florian Pflug" <fgp(at)phlo(dot)org>,<pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Review: Row-level Locks & SERIALIZABLE transactions, postgres vs. Oracle |
| Date: | 2010-09-24 21:19:14 |
| Message-ID: | 4C9CCF820200002500035D1C@gw.wicourts.gov |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Kevin Grittner <grimkg(at)gmail(dot)com> wrote:
> This now compiles and passes regression tests. I still need to
> re-run all the other tests which Florian and I previously used to
> test the patch. I don't have any reason to expect that they will
> now fail, but one need to be thorough. Once that is confirmed, I
> think this will be ready for committer unless someone can think of
> something else to throw at it first.
I reran the tests at http://github.com/fgp/fk_concurrency and,
unsurprisingly, it still works.
This patch addresses concerns I heard expressed by a couple guys
from an Oracle shop who wanted to convert to PostgreSQL but were
much put out by the behavior of SELECT FOR UPDATE under snapshot
isolation in PostgreSQL. This patch should do much to ease the
migration of some Oracle shops to PostgreSQL.
A complete review was done in the last CF, but I held off marking it
as Ready for Committer then because there were some more tests
coming, which all looked good.
http://archives.postgresql.org/message-id/4C41932002000025000337FB@gw.wicourts.gov
I am marking this patch "Ready for Committer" now.
-Kevin