psql: \dg off by one error

Lists: pgsql-hackers
From: Josh Kupershmidt <schmiddy(at)gmail(dot)com>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: psql: \dg off by one error
Date: 2011-02-27 00:21:05
Message-ID: AANLkTimgbL9SHLXj38Qtmo6vmuwocW5rRLCKWQmO1bxE@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Hi all,

I noticed an off by one error in psql's verbose-mode display for \dg
and \du. In verbose mode, \dg and \du will not display the
"Replication" attribute:

test=# \dg rep
List of roles
Role name | Attributes | Member of
-----------+-------------+-----------
rep | Replication | {}

test=# \dg+ rep
List of roles
Role name | Attributes | Member of | Description
-----------+------------+-----------+-------------
rep | | {} |

Attached is a one line patch to fix.

Josh

Attachment Content-Type Size
psql_replication_display.patch text/x-patch 720 bytes
From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Josh Kupershmidt <schmiddy(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: psql: \dg off by one error
Date: 2011-02-27 11:38:47
Message-ID: AANLkTi=cqWMKQqa_HeUJiUd7r6XU+RCtp8oDUYJyEdXC@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Sun, Feb 27, 2011 at 01:21, Josh Kupershmidt <schmiddy(at)gmail(dot)com> wrote:
> Hi all,
>
> I noticed an off by one error in psql's verbose-mode display for \dg
> and \du. In verbose mode, \dg and \du will not display the
> "Replication" attribute:
>
> test=# \dg rep
>            List of roles
>  Role name | Attributes  | Member of
> -----------+-------------+-----------
>  rep       | Replication | {}
>
> test=# \dg+ rep
>                  List of roles
>  Role name | Attributes | Member of | Description
> -----------+------------+-----------+-------------
>  rep       |            | {}        |
>
>
> Attached is a one line patch to fix.

Applied, thanks.

--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/