| Lists: | pgadmin-support |
|---|
| From: | Josh Berkus <josh(at)agliodbs(dot)com> |
|---|---|
| To: | PgAdmin Support <pgadmin-support(at)postgresql(dot)org> |
| Subject: | Minor UI issues for Server Properties dialog box |
| Date: | 2011-01-15 22:58:30 |
| Message-ID: | 4D322696.5040807@agliodbs.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgadmin-support |
Nothing showstopping, but:
1) After you make changes in the Server Properties dialog, it gives you
the fairly useless message that "Some changes will not take effect until
the next time pgAdmin connects to the server". The reason this message
is useless (and annoying) is that pgAdmin prevents you from changing
those fields unless you are disconnected from the server in the first place.
2) Changes to server properties are not saved until the user shuts down
pgAdmin. This means that in the event of a crash all server property
changes are lost.
--
-- Josh Berkus
PostgreSQL Experts Inc.
http://www.pgexperts.com
| From: | Guillaume Lelarge <guillaume(at)lelarge(dot)info> |
|---|---|
| To: | Josh Berkus <josh(at)agliodbs(dot)com> |
| Cc: | PgAdmin Support <pgadmin-support(at)postgresql(dot)org> |
| Subject: | Re: Minor UI issues for Server Properties dialog box |
| Date: | 2011-01-15 23:17:11 |
| Message-ID: | 4D322AF7.6000601@lelarge.info |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgadmin-support |
Le 15/01/2011 23:58, Josh Berkus a écrit :
> Nothing showstopping, but:
>
> 1) After you make changes in the Server Properties dialog, it gives you
> the fairly useless message that "Some changes will not take effect until
> the next time pgAdmin connects to the server". The reason this message
> is useless (and annoying) is that pgAdmin prevents you from changing
> those fields unless you are disconnected from the server in the first place.
>
Yeah, I don't like it either. Need to be fixed.
> 2) Changes to server properties are not saved until the user shuts down
> pgAdmin. This means that in the event of a crash all server property
> changes are lost.
>
Dave already fixed it. It will be available in 1.14.
--
Guillaume
http://www.postgresql.fr
http://dalibo.com
| From: | Josh Berkus <josh(at)agliodbs(dot)com> |
|---|---|
| To: | PgAdmin Support <pgadmin-support(at)postgresql(dot)org> |
| Subject: | Re: Minor UI issues for Server Properties dialog box |
| Date: | 2011-01-16 00:04:59 |
| Message-ID: | 4D32362B.10901@agliodbs.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgadmin-support |
> Dave already fixed it. It will be available in 1.14.
Great. Glad to hear it!
--
-- Josh Berkus
PostgreSQL Experts Inc.
http://www.pgexperts.com
| From: | Dave Page <dpage(at)pgadmin(dot)org> |
|---|---|
| To: | Guillaume Lelarge <guillaume(at)lelarge(dot)info> |
| Cc: | Josh Berkus <josh(at)agliodbs(dot)com>, PgAdmin Support <pgadmin-support(at)postgresql(dot)org> |
| Subject: | Re: Minor UI issues for Server Properties dialog box |
| Date: | 2011-01-16 08:32:01 |
| Message-ID: | AANLkTimXg6Y3BOxHGHuJX1S0ECe94m2BBLKdnohhz0=w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgadmin-support |
On Sat, Jan 15, 2011 at 11:17 PM, Guillaume Lelarge
<guillaume(at)lelarge(dot)info> wrote:
> Le 15/01/2011 23:58, Josh Berkus a écrit :
>> Nothing showstopping, but:
>>
>> 1) After you make changes in the Server Properties dialog, it gives you
>> the fairly useless message that "Some changes will not take effect until
>> the next time pgAdmin connects to the server". The reason this message
>> is useless (and annoying) is that pgAdmin prevents you from changing
>> those fields unless you are disconnected from the server in the first place.
>>
>
> Yeah, I don't like it either. Need to be fixed.
Actually, it is correct; you can tweak the DB Restriction, but it
needs a full refresh to take effect. That said, it is inconsistent
from other settings.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From: | Guillaume Lelarge <guillaume(at)lelarge(dot)info> |
|---|---|
| To: | Dave Page <dpage(at)pgadmin(dot)org> |
| Cc: | Josh Berkus <josh(at)agliodbs(dot)com>, PgAdmin Support <pgadmin-support(at)postgresql(dot)org> |
| Subject: | Re: Minor UI issues for Server Properties dialog box |
| Date: | 2011-01-19 22:38:38 |
| Message-ID: | 4D3767EE.7060607@lelarge.info |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgadmin-support |
Le 16/01/2011 09:32, Dave Page a écrit :
> On Sat, Jan 15, 2011 at 11:17 PM, Guillaume Lelarge
> <guillaume(at)lelarge(dot)info> wrote:
>> Le 15/01/2011 23:58, Josh Berkus a écrit :
>>> Nothing showstopping, but:
>>>
>>> 1) After you make changes in the Server Properties dialog, it gives you
>>> the fairly useless message that "Some changes will not take effect until
>>> the next time pgAdmin connects to the server". The reason this message
>>> is useless (and annoying) is that pgAdmin prevents you from changing
>>> those fields unless you are disconnected from the server in the first place.
>>>
>>
>> Yeah, I don't like it either. Need to be fixed.
>
> Actually, it is correct; you can tweak the DB Restriction, but it
> needs a full refresh to take effect. That said, it is inconsistent
> from other settings.
>
>
I commited a patch that simply displays the message only when the user
is connected to the server.
Now, what I would like to know is if the other settings should stay
disabled? why only some of them are disabled (or enabled)? shouldn't we
just make them all enabled?
--
Guillaume
http://www.postgresql.fr
http://dalibo.com
| From: | Dave Page <dpage(at)pgadmin(dot)org> |
|---|---|
| To: | Guillaume Lelarge <guillaume(at)lelarge(dot)info> |
| Cc: | Josh Berkus <josh(at)agliodbs(dot)com>, PgAdmin Support <pgadmin-support(at)postgresql(dot)org> |
| Subject: | Re: Minor UI issues for Server Properties dialog box |
| Date: | 2011-01-19 22:42:21 |
| Message-ID: | AANLkTikoVoNuTCZs6BmH837-4=k1LQkY3=TERRGEbny6@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgadmin-support |
On Wed, Jan 19, 2011 at 10:38 PM, Guillaume Lelarge
<guillaume(at)lelarge(dot)info> wrote:
> Le 16/01/2011 09:32, Dave Page a écrit :
>> On Sat, Jan 15, 2011 at 11:17 PM, Guillaume Lelarge
>> <guillaume(at)lelarge(dot)info> wrote:
>>> Le 15/01/2011 23:58, Josh Berkus a écrit :
>>>> Nothing showstopping, but:
>>>>
>>>> 1) After you make changes in the Server Properties dialog, it gives you
>>>> the fairly useless message that "Some changes will not take effect until
>>>> the next time pgAdmin connects to the server". The reason this message
>>>> is useless (and annoying) is that pgAdmin prevents you from changing
>>>> those fields unless you are disconnected from the server in the first place.
>>>>
>>>
>>> Yeah, I don't like it either. Need to be fixed.
>>
>> Actually, it is correct; you can tweak the DB Restriction, but it
>> needs a full refresh to take effect. That said, it is inconsistent
>> from other settings.
>>
>>
>
> I commited a patch that simply displays the message only when the user
> is connected to the server.
>
> Now, what I would like to know is if the other settings should stay
> disabled? why only some of them are disabled (or enabled)? shouldn't we
> just make them all enabled?
I'd be inclined to make them all disabled.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From: | Guillaume Lelarge <guillaume(at)lelarge(dot)info> |
|---|---|
| To: | Dave Page <dpage(at)pgadmin(dot)org> |
| Cc: | Josh Berkus <josh(at)agliodbs(dot)com>, PgAdmin Support <pgadmin-support(at)postgresql(dot)org> |
| Subject: | Re: Minor UI issues for Server Properties dialog box |
| Date: | 2011-01-19 22:51:06 |
| Message-ID: | 4D376ADA.7070707@lelarge.info |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgadmin-support |
Le 19/01/2011 23:42, Dave Page a écrit :
> On Wed, Jan 19, 2011 at 10:38 PM, Guillaume Lelarge
> <guillaume(at)lelarge(dot)info> wrote:
>> Le 16/01/2011 09:32, Dave Page a écrit :
>>> On Sat, Jan 15, 2011 at 11:17 PM, Guillaume Lelarge
>>> <guillaume(at)lelarge(dot)info> wrote:
>>>> Le 15/01/2011 23:58, Josh Berkus a écrit :
>>>>> Nothing showstopping, but:
>>>>>
>>>>> 1) After you make changes in the Server Properties dialog, it gives you
>>>>> the fairly useless message that "Some changes will not take effect until
>>>>> the next time pgAdmin connects to the server". The reason this message
>>>>> is useless (and annoying) is that pgAdmin prevents you from changing
>>>>> those fields unless you are disconnected from the server in the first place.
>>>>>
>>>>
>>>> Yeah, I don't like it either. Need to be fixed.
>>>
>>> Actually, it is correct; you can tweak the DB Restriction, but it
>>> needs a full refresh to take effect. That said, it is inconsistent
>>> from other settings.
>>>
>>>
>>
>> I commited a patch that simply displays the message only when the user
>> is connected to the server.
>>
>> Now, what I would like to know is if the other settings should stay
>> disabled? why only some of them are disabled (or enabled)? shouldn't we
>> just make them all enabled?
>
> I'd be inclined to make them all disabled.
>
When one is connected, right? (if not, we couldn't do much after
creating it :) ). Which means we would get rid of the message, as a user
won't be able to change server's settings once connected to it. Makes
sense to me. Working on it.
--
Guillaume
http://www.postgresql.fr
http://dalibo.com
| From: | Guillaume Lelarge <guillaume(at)lelarge(dot)info> |
|---|---|
| To: | Dave Page <dpage(at)pgadmin(dot)org> |
| Cc: | Josh Berkus <josh(at)agliodbs(dot)com>, PgAdmin Support <pgadmin-support(at)postgresql(dot)org> |
| Subject: | Re: Minor UI issues for Server Properties dialog box |
| Date: | 2011-01-19 23:10:03 |
| Message-ID: | 4D376F4B.9020002@lelarge.info |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgadmin-support |
Le 19/01/2011 23:51, Guillaume Lelarge a écrit :
> Le 19/01/2011 23:42, Dave Page a écrit :
>> On Wed, Jan 19, 2011 at 10:38 PM, Guillaume Lelarge
>> <guillaume(at)lelarge(dot)info> wrote:
>>> Le 16/01/2011 09:32, Dave Page a écrit :
>>>> On Sat, Jan 15, 2011 at 11:17 PM, Guillaume Lelarge
>>>> <guillaume(at)lelarge(dot)info> wrote:
>>>>> Le 15/01/2011 23:58, Josh Berkus a écrit :
>>>>>> Nothing showstopping, but:
>>>>>>
>>>>>> 1) After you make changes in the Server Properties dialog, it gives you
>>>>>> the fairly useless message that "Some changes will not take effect until
>>>>>> the next time pgAdmin connects to the server". The reason this message
>>>>>> is useless (and annoying) is that pgAdmin prevents you from changing
>>>>>> those fields unless you are disconnected from the server in the first place.
>>>>>>
>>>>>
>>>>> Yeah, I don't like it either. Need to be fixed.
>>>>
>>>> Actually, it is correct; you can tweak the DB Restriction, but it
>>>> needs a full refresh to take effect. That said, it is inconsistent
>>>> from other settings.
>>>>
>>>>
>>>
>>> I commited a patch that simply displays the message only when the user
>>> is connected to the server.
>>>
>>> Now, what I would like to know is if the other settings should stay
>>> disabled? why only some of them are disabled (or enabled)? shouldn't we
>>> just make them all enabled?
>>
>> I'd be inclined to make them all disabled.
>>
>
> When one is connected, right? (if not, we couldn't do much after
> creating it :) ). Which means we would get rid of the message, as a user
> won't be able to change server's settings once connected to it. Makes
> sense to me. Working on it.
>
Got a patch, but I'm wondering if this is 1.12 material? or is it 1.14
only? actually, Josh's bug is fixed, so this could be 1.14 only. Any
opinions on this matter?
--
Guillaume
http://www.postgresql.fr
http://dalibo.com
| Attachment | Content-Type | Size |
|---|---|---|
| disableall.patch | text/x-diff | 2.3 KB |
| From: | Dave Page <dpage(at)pgadmin(dot)org> |
|---|---|
| To: | Guillaume Lelarge <guillaume(at)lelarge(dot)info> |
| Cc: | Josh Berkus <josh(at)agliodbs(dot)com>, PgAdmin Support <pgadmin-support(at)postgresql(dot)org> |
| Subject: | Re: Minor UI issues for Server Properties dialog box |
| Date: | 2011-01-19 23:18:26 |
| Message-ID: | AANLkTimXjoBfcc-8+Q2qyXQPKyQE_a1rys6G+=mU+7Z8@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgadmin-support |
On Wed, Jan 19, 2011 at 11:10 PM, Guillaume Lelarge
<guillaume(at)lelarge(dot)info> wrote:
> Le 19/01/2011 23:51, Guillaume Lelarge a écrit :
>> Le 19/01/2011 23:42, Dave Page a écrit :
>>> On Wed, Jan 19, 2011 at 10:38 PM, Guillaume Lelarge
>>> <guillaume(at)lelarge(dot)info> wrote:
>>>> Le 16/01/2011 09:32, Dave Page a écrit :
>>>>> On Sat, Jan 15, 2011 at 11:17 PM, Guillaume Lelarge
>>>>> <guillaume(at)lelarge(dot)info> wrote:
>>>>>> Le 15/01/2011 23:58, Josh Berkus a écrit :
>>>>>>> Nothing showstopping, but:
>>>>>>>
>>>>>>> 1) After you make changes in the Server Properties dialog, it gives you
>>>>>>> the fairly useless message that "Some changes will not take effect until
>>>>>>> the next time pgAdmin connects to the server". The reason this message
>>>>>>> is useless (and annoying) is that pgAdmin prevents you from changing
>>>>>>> those fields unless you are disconnected from the server in the first place.
>>>>>>>
>>>>>>
>>>>>> Yeah, I don't like it either. Need to be fixed.
>>>>>
>>>>> Actually, it is correct; you can tweak the DB Restriction, but it
>>>>> needs a full refresh to take effect. That said, it is inconsistent
>>>>> from other settings.
>>>>>
>>>>>
>>>>
>>>> I commited a patch that simply displays the message only when the user
>>>> is connected to the server.
>>>>
>>>> Now, what I would like to know is if the other settings should stay
>>>> disabled? why only some of them are disabled (or enabled)? shouldn't we
>>>> just make them all enabled?
>>>
>>> I'd be inclined to make them all disabled.
>>>
>>
>> When one is connected, right? (if not, we couldn't do much after
>> creating it :) ). Which means we would get rid of the message, as a user
>> won't be able to change server's settings once connected to it. Makes
>> sense to me. Working on it.
>>
>
> Got a patch, but I'm wondering if this is 1.12 material? or is it 1.14
> only? actually, Josh's bug is fixed, so this could be 1.14 only. Any
> opinions on this matter?
1.14.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From: | Guillaume Lelarge <guillaume(at)lelarge(dot)info> |
|---|---|
| To: | Dave Page <dpage(at)pgadmin(dot)org> |
| Cc: | Josh Berkus <josh(at)agliodbs(dot)com>, PgAdmin Support <pgadmin-support(at)postgresql(dot)org> |
| Subject: | Re: Minor UI issues for Server Properties dialog box |
| Date: | 2011-01-20 07:36:35 |
| Message-ID: | 4D37E603.8020407@lelarge.info |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgadmin-support |
Le 20/01/2011 00:18, Dave Page a écrit :
> On Wed, Jan 19, 2011 at 11:10 PM, Guillaume Lelarge
> <guillaume(at)lelarge(dot)info> wrote:
>> Le 19/01/2011 23:51, Guillaume Lelarge a écrit :
>>> Le 19/01/2011 23:42, Dave Page a écrit :
>>>> On Wed, Jan 19, 2011 at 10:38 PM, Guillaume Lelarge
>>>> <guillaume(at)lelarge(dot)info> wrote:
>>>>> Le 16/01/2011 09:32, Dave Page a écrit :
>>>>>> On Sat, Jan 15, 2011 at 11:17 PM, Guillaume Lelarge
>>>>>> <guillaume(at)lelarge(dot)info> wrote:
>>>>>>> Le 15/01/2011 23:58, Josh Berkus a écrit :
>>>>>>>> Nothing showstopping, but:
>>>>>>>>
>>>>>>>> 1) After you make changes in the Server Properties dialog, it gives you
>>>>>>>> the fairly useless message that "Some changes will not take effect until
>>>>>>>> the next time pgAdmin connects to the server". The reason this message
>>>>>>>> is useless (and annoying) is that pgAdmin prevents you from changing
>>>>>>>> those fields unless you are disconnected from the server in the first place.
>>>>>>>>
>>>>>>>
>>>>>>> Yeah, I don't like it either. Need to be fixed.
>>>>>>
>>>>>> Actually, it is correct; you can tweak the DB Restriction, but it
>>>>>> needs a full refresh to take effect. That said, it is inconsistent
>>>>>> from other settings.
>>>>>>
>>>>>>
>>>>>
>>>>> I commited a patch that simply displays the message only when the user
>>>>> is connected to the server.
>>>>>
>>>>> Now, what I would like to know is if the other settings should stay
>>>>> disabled? why only some of them are disabled (or enabled)? shouldn't we
>>>>> just make them all enabled?
>>>>
>>>> I'd be inclined to make them all disabled.
>>>>
>>>
>>> When one is connected, right? (if not, we couldn't do much after
>>> creating it :) ). Which means we would get rid of the message, as a user
>>> won't be able to change server's settings once connected to it. Makes
>>> sense to me. Working on it.
>>>
>>
>> Got a patch, but I'm wondering if this is 1.12 material? or is it 1.14
>> only? actually, Josh's bug is fixed, so this could be 1.14 only. Any
>> opinions on this matter?
>
> 1.14.
>
Done. Thanks.
--
Guillaume
http://www.postgresql.fr
http://dalibo.com