| Lists: | pgsql-hackers |
|---|
| From: | Andy Lester <andy(at)petdance(dot)com> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | PATCH: Minor notes in CLUSTER page |
| Date: | 2010-05-06 19:29:55 |
| Message-ID: | 20100506192955.GA19487@petdance.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
I was looking for how to undo a CLUSTER call earlier today. Nothing on
the CLUSTER page told me how to do it, or pointed me to the ALTER TABLE
page. I figure a pointer to would help the next person in my situation.
xoxo,
Andy
--
Andy Lester => andy(at)petdance(dot)com => www.petdance.com => AIM:petdance
| Attachment | Content-Type | Size |
|---|---|---|
| cluster-docs.patch | text/plain | 731 bytes |
| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Andy Lester <andy(at)petdance(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: PATCH: Minor notes in CLUSTER page |
| Date: | 2010-05-07 11:33:55 |
| Message-ID: | AANLkTim0MfwVArq9tWy3QahDmcOxc-i1KrZokdB1ysT7@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Thu, May 6, 2010 at 3:29 PM, Andy Lester <andy(at)petdance(dot)com> wrote:
> I was looking for how to undo a CLUSTER call earlier today. Nothing on
> the CLUSTER page told me how to do it, or pointed me to the ALTER TABLE
> page. I figure a pointer to would help the next person in my situation.
I've been annoyed by this too and so am in favor of adding a mention
in the documentation, but I think we should mention both the CLUSTER
and SET WITHOUT CLUSTER variants of ALTER TABLE, and since it's only
one sentence I think we should add it adjacent to the existing
sentence discussing remembering the index. My proposed patch
attached; thoughts?
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company
| Attachment | Content-Type | Size |
|---|---|---|
| cluster-docs-rmh.patch | application/octet-stream | 796 bytes |
| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Andy Lester <andy(at)petdance(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: PATCH: Minor notes in CLUSTER page |
| Date: | 2010-05-07 14:44:57 |
| Message-ID: | 1273243295-sup-3199@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Excerpts from Robert Haas's message of vie may 07 07:33:55 -0400 2010:
> On Thu, May 6, 2010 at 3:29 PM, Andy Lester <andy(at)petdance(dot)com> wrote:
> > I was looking for how to undo a CLUSTER call earlier today. Nothing on
> > the CLUSTER page told me how to do it, or pointed me to the ALTER TABLE
> > page. I figure a pointer to would help the next person in my situation.
>
> I've been annoyed by this too and so am in favor of adding a mention
> in the documentation, but I think we should mention both the CLUSTER
> and SET WITHOUT CLUSTER variants of ALTER TABLE, and since it's only
> one sentence I think we should add it adjacent to the existing
> sentence discussing remembering the index. My proposed patch
> attached; thoughts?
dept. of minor nitpicks:
change
+ use <literal>CLUSTER</literal> or <literal>SET WITHOUT CLUSTER</literal>
to
+ use the <literal>CLUSTER ON</literal> or <literal>SET WITHOUT CLUSTER</literal>
Other than that, +1 from me.
(Hmm, perhaps even say what each form is for right after mentioning it, instead
of mentioning both and then saying what both are for.)
--
| From: | Andy Lester <andy(at)petdance(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: PATCH: Minor notes in CLUSTER page |
| Date: | 2010-05-07 14:48:29 |
| Message-ID: | BAC6956D-B7BC-4951-BDBB-5902687337EE@petdance.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
> nly
> one sentence I think we should add it adjacent to the existing
> sentence discussing remembering the index. My proposed patch
> attached; thoughts?
As long as there's a pointer to the answer I'm happy.
xoa
--
Andy Lester => andy(at)petdance(dot)com => www.theworkinggeek.com => AIM:petdance
| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Andy Lester <andy(at)petdance(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: PATCH: Minor notes in CLUSTER page |
| Date: | 2010-05-07 20:49:26 |
| Message-ID: | AANLkTilJcluc8fxMyhvC6FBxUZgQk76OCnawrq01wqUx@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Fri, May 7, 2010 at 10:44 AM, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
> Excerpts from Robert Haas's message of vie may 07 07:33:55 -0400 2010:
>> On Thu, May 6, 2010 at 3:29 PM, Andy Lester <andy(at)petdance(dot)com> wrote:
>> > I was looking for how to undo a CLUSTER call earlier today. Nothing on
>> > the CLUSTER page told me how to do it, or pointed me to the ALTER TABLE
>> > page. I figure a pointer to would help the next person in my situation.
>>
>> I've been annoyed by this too and so am in favor of adding a mention
>> in the documentation, but I think we should mention both the CLUSTER
>> and SET WITHOUT CLUSTER variants of ALTER TABLE, and since it's only
>> one sentence I think we should add it adjacent to the existing
>> sentence discussing remembering the index. My proposed patch
>> attached; thoughts?
>
> dept. of minor nitpicks:
>
> change
> + use <literal>CLUSTER</literal> or <literal>SET WITHOUT CLUSTER</literal>
>
> to
> + use the <literal>CLUSTER ON</literal> or <literal>SET WITHOUT CLUSTER</literal>
>
> Other than that, +1 from me.
>
> (Hmm, perhaps even say what each form is for right after mentioning it, instead
> of mentioning both and then saying what both are for.)
I couldn't think of a way to phrase that that was any better than the
way I wrote it and still allowed me to include an xref to the ALTER
TABLE page in a natural way. I am however open to suggestions.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company
| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Andy Lester <andy(at)petdance(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: PATCH: Minor notes in CLUSTER page |
| Date: | 2010-05-11 16:08:04 |
| Message-ID: | AANLkTimQ3sgPbfzM99qGC2FuLgiwyJECTxror4F-YKtL@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Fri, May 7, 2010 at 10:44 AM, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
> Excerpts from Robert Haas's message of vie may 07 07:33:55 -0400 2010:
>> On Thu, May 6, 2010 at 3:29 PM, Andy Lester <andy(at)petdance(dot)com> wrote:
>> > I was looking for how to undo a CLUSTER call earlier today. Nothing on
>> > the CLUSTER page told me how to do it, or pointed me to the ALTER TABLE
>> > page. I figure a pointer to would help the next person in my situation.
>>
>> I've been annoyed by this too and so am in favor of adding a mention
>> in the documentation, but I think we should mention both the CLUSTER
>> and SET WITHOUT CLUSTER variants of ALTER TABLE, and since it's only
>> one sentence I think we should add it adjacent to the existing
>> sentence discussing remembering the index. My proposed patch
>> attached; thoughts?
>
> dept. of minor nitpicks:
>
> change
> + use <literal>CLUSTER</literal> or <literal>SET WITHOUT CLUSTER</literal>
>
> to
> + use the <literal>CLUSTER ON</literal> or <literal>SET WITHOUT CLUSTER</literal>
>
> Other than that, +1 from me.
Committed with that change.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company