| Lists: | pgsql-hackers |
|---|
| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Bug in parse_basebackup_options Re: [COMMITTERS] pgsql: Make walsender options order-independent |
| Date: | 2011-01-25 09:32:11 |
| Message-ID: | AANLkTi=udLRSu8gEr9J+q9=KzF-Tra+rHWJbthS9w1Oi@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Mon, Jan 24, 2011 at 7:41 AM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
> Make walsender options order-independent
>
> While doing this, also move base backup options into
> a struct instead of increasing the number of parameters
> to multiple functions for each new option.
When I read the include-WAL-in-backup patch, I found that this
commit had the bug; parse_basebackup_options fails in parsing
options because of wrong usage of MemSet. Here is the patch.
Regards,
--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
| Attachment | Content-Type | Size |
|---|---|---|
| parse_basebackup_options_bugfix_v1.patch | application/octet-stream | 542 bytes |
| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Bug in parse_basebackup_options Re: [COMMITTERS] pgsql: Make walsender options order-independent |
| Date: | 2011-01-25 09:51:01 |
| Message-ID: | AANLkTim=kJTgyCNSCQ3AwHWU5NthvOrGK+qkgC+x3FC3@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Tue, Jan 25, 2011 at 10:32, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> On Mon, Jan 24, 2011 at 7:41 AM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
>> Make walsender options order-independent
>>
>> While doing this, also move base backup options into
>> a struct instead of increasing the number of parameters
>> to multiple functions for each new option.
>
> When I read the include-WAL-in-backup patch, I found that this
> commit had the bug; parse_basebackup_options fails in parsing
> options because of wrong usage of MemSet. Here is the patch.
Wow. I know I fixed that at one point, it must've gone bad again in a
merge. Interestingly enough it works in my environment, but that must
be pure luck.
So thanks - applied.
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/