Re: READ ONLY fixes

Lists: pgsql-hackers
From: "Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov>
To: <robertmhaas(at)gmail(dot)com>
Cc: <jeff(dot)janes(at)gmail(dot)com>,<pgsql-hackers(at)postgresql(dot)org>
Subject: Re: READ ONLY fixes
Date: 2011-01-22 03:21:13
Message-ID: 4D39F8C90200002500039A3A@gw.wicourts.gov
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Robert Haas wrote:

> Upon further review, I am wondering if it wouldn't be simpler and
> more logical to allow idempotent changes of these settings at any
> time, and to restrict only changes that actually change something.

I don't care a lot about that either -- if I remember correctly, we
got here based largely on my somewhat tentative interpretation of the
standard. Even if my reading was right (of which I'm far from sure),
it would just mean that we have an extension to the standard in
allowing the benign declarations. I'm sure not going to lose any
sleep over that.

I'll do whatever people want in this regard with no reservations.

-Kevin


From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Kevin Grittner <Kevin(dot)Grittner(at)wicourts(dot)gov>
Cc: jeff(dot)janes(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: Re: READ ONLY fixes
Date: 2011-01-23 01:57:01
Message-ID: AANLkTim+SH3EH5nO6A+x9=YzAKsBUcev1CF+J9_JcGhE@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Fri, Jan 21, 2011 at 10:21 PM, Kevin Grittner
<Kevin(dot)Grittner(at)wicourts(dot)gov> wrote:
> Robert Haas  wrote:
>
>> Upon further review, I am wondering if it wouldn't be simpler and
>> more logical to allow idempotent changes of these settings at any
>> time, and to restrict only changes that actually change something.
>
> I don't care a lot about that either -- if I remember correctly, we
> got here based largely on my somewhat tentative interpretation of the
> standard.  Even if my reading was right (of which I'm far from sure),
> it would just mean that we have an extension to the standard in
> allowing the benign declarations.  I'm sure not going to lose any
> sleep over that.
>
> I'll do whatever people want in this regard with no reservations.

OK, I've committed this as proposed above.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company