| Lists: | pgsql-hackers |
|---|
| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | trace_recovery_messages |
| Date: | 2010-06-17 06:41:47 |
| Message-ID: | AANLkTikYYsDfiTjHudniK79V5rOFyrwezv6TDr0rBRCL@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Hi,
We should make trace_recovery_messages available only when
the WAL_DEBUG macro was defined? Currently it's always
available, so the standby seems to call elog() too frequently.
Regards,
--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: trace_recovery_messages |
| Date: | 2010-06-17 17:48:43 |
| Message-ID: | 22539.1276796923@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Fujii Masao <masao(dot)fujii(at)gmail(dot)com> writes:
> We should make trace_recovery_messages available only when
> the WAL_DEBUG macro was defined?
No, because it's used in a lot of other contexts besides that.
> Currently it's always
> available, so the standby seems to call elog() too frequently.
Where? I don't see very many messages that would actually get emitted
at the default setting of the parameter.
regards, tom lane
| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: trace_recovery_messages |
| Date: | 2010-06-18 01:20:39 |
| Message-ID: | AANLkTilhOhiC3p5SOQz0R2XZrtGNBImxaRX7BRKq18a4@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Fri, Jun 18, 2010 at 2:48 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Fujii Masao <masao(dot)fujii(at)gmail(dot)com> writes:
>> We should make trace_recovery_messages available only when
>> the WAL_DEBUG macro was defined?
>
> No, because it's used in a lot of other contexts besides that.
>
>> Currently it's always
>> available, so the standby seems to call elog() too frequently.
>
> Where? I don't see very many messages that would actually get emitted
> at the default setting of the parameter.
Yes. I was just concerned that frequent calls themselves may increase
the overhead.
Regards,
--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
| From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: trace_recovery_messages |
| Date: | 2010-06-18 08:35:37 |
| Message-ID: | 1276850137.23257.81349.camel@ebony |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Fri, 2010-06-18 at 10:20 +0900, Fujii Masao wrote:
> On Fri, Jun 18, 2010 at 2:48 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > Fujii Masao <masao(dot)fujii(at)gmail(dot)com> writes:
> >> We should make trace_recovery_messages available only when
> >> the WAL_DEBUG macro was defined?
> >
> > No, because it's used in a lot of other contexts besides that.
> >
> >> Currently it's always
> >> available, so the standby seems to call elog() too frequently.
> >
> > Where? I don't see very many messages that would actually get emitted
> > at the default setting of the parameter.
>
> Yes. I was just concerned that frequent calls themselves may increase
> the overhead.
Please share your oprofile output so we can see the problem.
--
Simon Riggs www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Training and Services