| Lists: | pgsql-committers |
|---|
| From: | momjian(at)postgresql(dot)org (Bruce Momjian) |
|---|---|
| To: | pgsql-committers(at)postgresql(dot)org |
| Subject: | pgsql: Properly lowercase identifiers, uppercase keywords, in doc |
| Date: | 2010-08-11 21:48:51 |
| Message-ID: | 20100811214851.E8A4F7541D7@cvs.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-committers |
Log Message:
-----------
Properly lowercase identifiers, uppercase keywords, in doc examples
Modified Files:
--------------
pgsql/doc/src/sgml:
syntax.sgml (r1.150 -> r1.151)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/syntax.sgml?r1=1.150&r2=1.151)
| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Properly lowercase identifiers, uppercase keywords, in doc |
| Date: | 2010-08-11 22:04:07 |
| Message-ID: | 25532.1281564247@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-committers |
momjian(at)postgresql(dot)org (Bruce Momjian) writes:
> Log Message:
> -----------
> Properly lowercase identifiers, uppercase keywords, in doc examples
Bruce, did you do that with a blind sed script? You totally destroyed
the point of these examples. Kindly revert.
regards, tom lane
| From: | Thom Brown <thom(at)linux(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Properly lowercase identifiers, uppercase keywords, in doc |
| Date: | 2010-08-11 22:19:26 |
| Message-ID: | AANLkTikkA1qOpWarSXuUfHgCCnbyQKmj=X23sYWv9Ur9@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-committers |
On 11 August 2010 23:04, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> momjian(at)postgresql(dot)org (Bruce Momjian) writes:
>> Log Message:
>> -----------
>> Properly lowercase identifiers, uppercase keywords, in doc examples
>
> Bruce, did you do that with a blind sed script? You totally destroyed
> the point of these examples. Kindly revert.
>
Whilst that change definitely needs reverting, I noticed the following
doesn't read well:
"Additionally, comments can occur in SQL input. They are not tokens,
they are effectively equivalent to whitespace.
For example, the following is (syntactically) valid SQL input:"
You'd expect an example with comments in after reading that, but there isn't.
Maybe that "Additionally..." bit should be moved beneath the "This is
a sequence..." paragraph?
--
Thom Brown
Registered Linux user: #516935
| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Properly lowercase identifiers, uppercase keywords, in doc |
| Date: | 2010-08-12 02:04:50 |
| Message-ID: | 201008120204.o7C24oQ07526@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-committers |
Tom Lane wrote:
> momjian(at)postgresql(dot)org (Bruce Momjian) writes:
> > Log Message:
> > -----------
> > Properly lowercase identifiers, uppercase keywords, in doc examples
>
> Bruce, did you do that with a blind sed script? You totally destroyed
> the point of these examples. Kindly revert.
Oops, reverted. I was looking in there for something else and was
surprised that such odd casing had gotten into our docs.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ It's impossible for everything to be true. +