| Lists: | pgsql-hackers |
|---|
| From: | Marko Tiikkaja <marko(dot)tiikkaja(at)cs(dot)helsinki(dot)fi> |
|---|---|
| To: | Hitoshi Harada <umi(dot)tanuki(at)gmail(dot)com> |
| Cc: | Erik Rijkers <er(at)xs4all(dot)nl>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: top-level DML under CTEs |
| Date: | 2010-10-05 08:55:37 |
| Message-ID: | 4CAAE809.2000106@cs.helsinki.fi |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
(Oops, this didn't go to -HACKERS)
On 2010-10-04 2:46 PM +0300, Erik Rijkers wrote:
> (HEAD from git://git.postgresql.org/git/postgresql.git)
>
> The patch applies only with error.
> If that error is ignored, the regression 'with' test failes.
> If that is also ignored, it runs.
This patch conflicted with Tom's WITH .. INSERT change. I tweaked the
patch just a bit and it now passes all regression tests so I can review
it. New version attached for documentation purposes.
Regards,
Marko Tiikkaja
| Attachment | Content-Type | Size |
|---|---|---|
| dml.patch | text/plain | 21.0 KB |
| From: | Hitoshi Harada <umi(dot)tanuki(at)gmail(dot)com> |
|---|---|
| To: | Marko Tiikkaja <marko(dot)tiikkaja(at)cs(dot)helsinki(dot)fi> |
| Cc: | Erik Rijkers <er(at)xs4all(dot)nl>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: top-level DML under CTEs |
| Date: | 2010-10-05 12:37:52 |
| Message-ID: | AANLkTik1JCag5X6mOc+4pxFeZ03otyHyOjvEN_RAmrhp@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
2010/10/5 Marko Tiikkaja <marko(dot)tiikkaja(at)cs(dot)helsinki(dot)fi>:
> (Oops, this didn't go to -HACKERS)
>
> On 2010-10-04 2:46 PM +0300, Erik Rijkers wrote:
>>
>> (HEAD from git://git.postgresql.org/git/postgresql.git)
>>
>> The patch applies only with error.
>> If that error is ignored, the regression 'with' test failes.
>> If that is also ignored, it runs.
>
> This patch conflicted with Tom's WITH .. INSERT change. I tweaked the
> patch just a bit and it now passes all regression tests so I can review
> it. New version attached for documentation purposes.
Thank you, I didn't notice that commit. In your last patch, the
snippet to add errhint() and ref/insert sgml is unnecessary since it
was for INSERT ... VALUES fix.
Regards,
--
Hitoshi Harada
| Attachment | Content-Type | Size |
|---|---|---|
| toplevel-dml-cte.20101005.diff | application/octet-stream | 18.7 KB |
| From: | Marko Tiikkaja <marko(dot)tiikkaja(at)cs(dot)helsinki(dot)fi> |
|---|---|
| To: | Hitoshi Harada <umi(dot)tanuki(at)gmail(dot)com> |
| Cc: | Erik Rijkers <er(at)xs4all(dot)nl>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: top-level DML under CTEs |
| Date: | 2010-10-05 15:29:31 |
| Message-ID: | 4CAB445B.2020104@cs.helsinki.fi |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On 2010-10-05 3:37 PM +0300, Hitoshi Harada wrote:
> 2010/10/5 Marko Tiikkaja<marko(dot)tiikkaja(at)cs(dot)helsinki(dot)fi>:
>> This patch conflicted with Tom's WITH .. INSERT change. I tweaked the
>> patch just a bit and it now passes all regression tests so I can review
>> it. New version attached for documentation purposes.
>
> Thank you, I didn't notice that commit. In your last patch, the
> snippet to add errhint() and ref/insert sgml is unnecessary since it
> was for INSERT ... VALUES fix.
The patch seems to work for all cases I can think of.
I'm going to mark this one ready for committer.
Regards,
Marko Tiikkaja
| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Hitoshi Harada <umi(dot)tanuki(at)gmail(dot)com> |
| Cc: | Marko Tiikkaja <marko(dot)tiikkaja(at)cs(dot)helsinki(dot)fi>, Erik Rijkers <er(at)xs4all(dot)nl>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: top-level DML under CTEs |
| Date: | 2010-10-16 00:00:04 |
| Message-ID: | 24086.1287187204@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Hitoshi Harada <umi(dot)tanuki(at)gmail(dot)com> writes:
> 2010/10/5 Marko Tiikkaja <marko(dot)tiikkaja(at)cs(dot)helsinki(dot)fi>:
>> This patch conflicted with Tom's WITH .. INSERT change. I tweaked the
>> patch just a bit and it now passes all regression tests so I can review
>> it. New version attached for documentation purposes.
> Thank you, I didn't notice that commit. In your last patch, the
> snippet to add errhint() and ref/insert sgml is unnecessary since it
> was for INSERT ... VALUES fix.
Committed with minor fixes (mostly documentation improvements).
regards, tom lane