Quick Links

Re: pgsql: Remove useless whitespace at end of lines

Lists:	pgsql-committerspgsql-hackers

From:	Peter Eisentraut <peter_e(at)gmx(dot)net>
To:	pgsql-committers(at)postgresql(dot)org
Subject:	pgsql: Remove useless whitespace at end of lines
Date:	2010-11-23 20:52:18
Message-ID:	E1PKzqc-00018P-QS@gemulon.postgresql.org
Views:	Raw Message \| Whole Thread \| Download mbox \| Resend email
Lists:	pgsql-committers pgsql-hackers

Remove useless whitespace at end of lines

Branch
------
master

Details
-------
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=fc946c39aeacdff7df60c83fca6582985e8546c8

From:	Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To:	Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc:	pgsql-committers <pgsql-committers(at)postgresql(dot)org>
Subject:	Re: pgsql: Remove useless whitespace at end of lines
Date:	2010-11-24 22:15:27
Message-ID:	1290636874-sup-3724@alvh.no-ip.org
Views:	Raw Message \| Whole Thread \| Download mbox \| Resend email
Lists:	pgsql-committers pgsql-hackers

Excerpts from Peter Eisentraut's message of mar nov 23 17:52:18 -0300 2010:
> Remove useless whitespace at end of lines

This was stuck in the moderation queue because of message size limit (30
kB). Is it worth increasing that value?

--
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

From:	Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To:	Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc:	pgsql-hackers(at)postgresql(dot)org, pgsql-committers <pgsql-committers(at)postgresql(dot)org>
Subject:	Re: pgsql: Remove useless whitespace at end of lines
Date:	2010-11-24 22:45:34
Message-ID:	23765.1290638734@sss.pgh.pa.us
Views:	Raw Message \| Whole Thread \| Download mbox \| Resend email
Lists:	pgsql-committers pgsql-hackers

Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> Excerpts from Peter Eisentraut's message of mar nov 23 17:52:18 -0300 2010:
>> Remove useless whitespace at end of lines

> This was stuck in the moderation queue because of message size limit (30
> kB). Is it worth increasing that value?

Evidently we should. pgindent and copyright-update commits are likely
to be at least this long.

regards, tom lane

From:	Magnus Hagander <magnus(at)hagander(dot)net>
To:	Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc:	Alvaro Herrera <alvherre(at)commandprompt(dot)com>, pgsql-hackers(at)postgresql(dot)org, pgsql-committers <pgsql-committers(at)postgresql(dot)org>
Subject:	Re: pgsql: Remove useless whitespace at end of lines
Date:	2010-11-24 22:46:30
Message-ID:	AANLkTi=4SX5vUK=sgLNRtf+rEz6qt7i5oyQTRPUg1GQ2@mail.gmail.com
Views:	Raw Message \| Whole Thread \| Download mbox \| Resend email
Lists:	pgsql-committers pgsql-hackers

On Wed, Nov 24, 2010 at 23:45, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
>> Excerpts from Peter Eisentraut's message of mar nov 23 17:52:18 -0300 2010:
>>> Remove useless whitespace at end of lines
>
>> This was stuck in the moderation queue because of message size limit (30
>> kB). Is it worth increasing that value?
>
> Evidently we should. pgindent and copyright-update commits are likely
> to be at least this long.

That's twice a year only - I don't see a big problem moderating those
when it happens...

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/

From:	Bruce Momjian <bruce(at)momjian(dot)us>
To:	Magnus Hagander <magnus(at)hagander(dot)net>
Cc:	Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, pgsql-hackers(at)postgresql(dot)org, pgsql-committers <pgsql-committers(at)postgresql(dot)org>
Subject:	Re: [HACKERS] pgsql: Remove useless whitespace at end of lines
Date:	2010-11-24 22:48:40
Message-ID:	201011242248.oAOMmeP02222@momjian.us
Views:	Raw Message \| Whole Thread \| Download mbox \| Resend email
Lists:	pgsql-committers pgsql-hackers

Magnus Hagander wrote:
> On Wed, Nov 24, 2010 at 23:45, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> >> Excerpts from Peter Eisentraut's message of mar nov 23 17:52:18 -0300 2010:
> >>> Remove useless whitespace at end of lines
> >
> >> This was stuck in the moderation queue because of message size limit (30
> >> kB). ?Is it worth increasing that value?
> >
> > Evidently we should. ?pgindent and copyright-update commits are likely
> > to be at least this long.
>
> That's twice a year only - I don't see a big problem moderating those
> when it happens...

I do love to see my big pgindent commits come through. You can hear the
wind rustling though the code.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

From:	Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To:	Magnus Hagander <magnus(at)hagander(dot)net>
Cc:	Alvaro Herrera <alvherre(at)commandprompt(dot)com>, pgsql-hackers(at)postgresql(dot)org, pgsql-committers <pgsql-committers(at)postgresql(dot)org>
Subject:	Re: pgsql: Remove useless whitespace at end of lines
Date:	2010-11-24 22:54:31
Message-ID:	23996.1290639271@sss.pgh.pa.us
Views:	Raw Message \| Whole Thread \| Download mbox \| Resend email
Lists:	pgsql-committers pgsql-hackers

Magnus Hagander <magnus(at)hagander(dot)net> writes:
> On Wed, Nov 24, 2010 at 23:45, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
>>> This was stuck in the moderation queue because of message size limit (30
>>> kB). Is it worth increasing that value?
>>
>> Evidently we should. pgindent and copyright-update commits are likely
>> to be at least this long.

> That's twice a year only - I don't see a big problem moderating those
> when it happens...

Its not so much the moderation load, as I don't like being blindsided by
commits that touch everything in sight. Finding out only when you try
to do git push (as indeed happened to me just this afternoon because of
this patch) is annoying.

regards, tom lane

From:	Magnus Hagander <magnus(at)hagander(dot)net>
To:	Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc:	Alvaro Herrera <alvherre(at)commandprompt(dot)com>, pgsql-hackers(at)postgresql(dot)org, pgsql-committers <pgsql-committers(at)postgresql(dot)org>
Subject:	Re: pgsql: Remove useless whitespace at end of lines
Date:	2010-11-25 08:46:49
Message-ID:	AANLkTi=RKadbUqGSOqCzp+Mfhw2K3=meGDHATA1XwW_1@mail.gmail.com
Views:	Raw Message \| Whole Thread \| Download mbox \| Resend email
Lists:	pgsql-committers pgsql-hackers

On Wed, Nov 24, 2010 at 23:54, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>> On Wed, Nov 24, 2010 at 23:45, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
>>>> This was stuck in the moderation queue because of message size limit (30
>>>> kB). Is it worth increasing that value?
>>>
>>> Evidently we should. pgindent and copyright-update commits are likely
>>> to be at least this long.
>
>> That's twice a year only - I don't see a big problem moderating those
>> when it happens...
>
> Its not so much the moderation load, as I don't like being blindsided by
> commits that touch everything in sight. Finding out only when you try
> to do git push (as indeed happened to me just this afternoon because of
> this patch) is annoying.

fair enough. I'm not sure the size limit actually protects us against
anything, so I'm not against increasing it.

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/

From:	Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To:	Magnus Hagander <magnus(at)hagander(dot)net>
Cc:	Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, pgsql-committers <pgsql-committers(at)postgresql(dot)org>
Subject:	Re: pgsql: Remove useless whitespace at end of lines
Date:	2010-11-25 12:55:02
Message-ID:	1290689533-sup-5489@alvh.no-ip.org
Views:	Raw Message \| Whole Thread \| Download mbox \| Resend email
Lists:	pgsql-committers pgsql-hackers

Excerpts from Magnus Hagander's message of jue nov 25 05:46:49 -0300 2010:
> On Wed, Nov 24, 2010 at 23:54, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

> > Its not so much the moderation load, as I don't like being blindsided by
> > commits that touch everything in sight. Finding out only when you try
> > to do git push (as indeed happened to me just this afternoon because of
> > this patch) is annoying.
>
> fair enough. I'm not sure the size limit actually protects us against
> anything, so I'm not against increasing it.

So, given that this commit touched 517 files and resulted in a 47341b
message, the minimum size we should use is about 332kB for the 3633
files present in the source tree (I counted all the files, not just the
ones with copyright lines, out of pure laziness).

I've set the limit to 400 kB to have a wide safety margin. Large commits
should now pass through unmoderated.

--
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support