Re: Second l10n patch

Hi,

I send patch. It solves translation for object type names in reports.

Regards

Marek

2009/8/1 Marek Černocký <marek(at)manet(dot)cz>:
> Hi,
>
> I send patch. It solves translation for object type names in reports.

Should code like this use wxPLURAL?

int section = report->XmlCreateSection(wxString::Format(_("%s
dependents"), object->GetTranslatedTypeName().c_str()));

--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com

Le lundi 3 août 2009 à 11:57:02, Dave Page a écrit :
> 2009/8/1 Marek Černocký <marek(at)manet(dot)cz>:
> > Hi,
> >
> > I send patch. It solves translation for object type names in reports.
>
> Should code like this use wxPLURAL?
>
> int section = report->XmlCreateSection(wxString::Format(_("%s
> dependents"), object->GetTranslatedTypeName().c_str()));

No. We need wxPLURAL when we have a variable that tells us if it is plural or
not. In this code, there's nothing that gives us a hint about it.

Note that I didn't actually try this patch. Only read it.

--
Guillaume.
http://www.postgresqlfr.org
http://dalibo.com

Le lundi 3 août 2009 à 12:33:56, Guillaume Lelarge a écrit :
> Le lundi 3 août 2009 à 11:57:02, Dave Page a écrit :
> > 2009/8/1 Marek Černocký <marek(at)manet(dot)cz>:
> > > Hi,
> > >
> > > I send patch. It solves translation for object type names in reports.
> >
> > Should code like this use wxPLURAL?
> >
> > int section = report->XmlCreateSection(wxString::Format(_("%s
> > dependents"), object->GetTranslatedTypeName().c_str()));
>
> No. We need wxPLURAL when we have a variable that tells us if it is plural
> or not. In this code, there's nothing that gives us a hint about it.
>
> Note that I didn't actually try this patch. Only read it.

Just tried it, and it works the way I think it should. I can commit it if you
want.

--
Guillaume.
http://www.postgresqlfr.org
http://dalibo.com

2009/8/3 Guillaume Lelarge <guillaume(at)lelarge(dot)info>:
> Le lundi 3 août 2009 à 12:33:56, Guillaume Lelarge a écrit :
>> Le lundi 3 août 2009 à 11:57:02, Dave Page a écrit :
>> > 2009/8/1 Marek Černocký <marek(at)manet(dot)cz>:
>> > > Hi,
>> > >
>> > > I send patch. It solves translation for object type names in reports.
>> >
>> > Should code like this use wxPLURAL?
>> >
>> > int section = report->XmlCreateSection(wxString::Format(_("%s
>> > dependents"), object->GetTranslatedTypeName().c_str()));
>>
>> No. We need wxPLURAL when we have a variable that tells us if it is plural
>> or not. In this code, there's nothing that gives us a hint about it.
>>
>> Note that I didn't actually try this patch. Only read it.
>
> Just tried it, and it works the way I think it should. I can commit it if you
> want.

Sure - thanks.

--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com

Le lundi 3 août 2009 à 13:04:34, Dave Page a écrit :
> 2009/8/3 Guillaume Lelarge <guillaume(at)lelarge(dot)info>:
> > Le lundi 3 août 2009 à 12:33:56, Guillaume Lelarge a écrit :
> >> Le lundi 3 août 2009 à 11:57:02, Dave Page a écrit :
> >> > 2009/8/1 Marek Černocký <marek(at)manet(dot)cz>:
> >> > > Hi,
> >> > >
> >> > > I send patch. It solves translation for object type names in
> >> > > reports.
> >> >
> >> > Should code like this use wxPLURAL?
> >> >
> >> > int section = report->XmlCreateSection(wxString::Format(_("%s
> >> > dependents"), object->GetTranslatedTypeName().c_str()));
> >>
> >> No. We need wxPLURAL when we have a variable that tells us if it is
> >> plural or not. In this code, there's nothing that gives us a hint about
> >> it.
> >>
> >> Note that I didn't actually try this patch. Only read it.
> >
> > Just tried it, and it works the way I think it should. I can commit it if
> > you want.
>
> Sure - thanks.

Done. Sorry for the two commits, I forgot the CHANGELOG file.

--
Guillaume.
http://www.postgresqlfr.org
http://dalibo.com