| Lists: | pgadmin-hackers |
|---|
| From: | "Dave Page" <dpage(at)pgadmin(dot)org> |
|---|---|
| To: | "Guillaume Lelarge" <guillaume(at)lelarge(dot)info> |
| Cc: | "Quan Zongliang" <quanzongliang(at)gmail(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: Newer server version warning (was: SVN Commit by dpage: r7544...) |
| Date: | 2009-01-12 13:32:18 |
| Message-ID: | 937d27e10901120532p3eb8b06o1db716c0b80b3428@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgadmin-hackers |
On Mon, Jan 12, 2009 at 1:18 PM, Guillaume Lelarge
<guillaume(at)lelarge(dot)info> wrote:
> Quan Zongliang a écrit :
>>>> Now, const float SERVER_MIN_VERSION = 7.3f; is defined in pgAdmin3.h.
>>>> Add a new variable SERVER_MAX_VERSION here.
>>>> When end-users try to connect to db, check the version.
>>>> If it is newer, display a warning dialog.
>>>> Then the end-users click <OK> button to continue.
>>
>> I think again. It's really not a good idea.
>> Another option is needed. Otherwise, when end users connect to db
>> with an older version pgAdmin. They will get message box always,
>> but the pgAdmin maybe work fine. This must make them very angry.
>>
>> Add a new option like "Don't check database version."?
>>
>
> I don't think so. pgAdmin should display the warning box only if they
> try to backup/restore, and not at startup time.
This is to prevent the user seeing errors when they run an old pgAdmin
against a newer server - it's not really about backup/restore (the
thread kinda changed subject).
--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com
| From: | Guillaume Lelarge <guillaume(at)lelarge(dot)info> |
|---|---|
| To: | Dave Page <dpage(at)pgadmin(dot)org> |
| Cc: | Quan Zongliang <quanzongliang(at)gmail(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: Newer server version warning (was: SVN Commit by dpage: r7544...) |
| Date: | 2009-01-12 13:34:23 |
| Message-ID: | 496B46DF.6080905@lelarge.info |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgadmin-hackers |
Dave Page a écrit :
> On Mon, Jan 12, 2009 at 1:18 PM, Guillaume Lelarge
> <guillaume(at)lelarge(dot)info> wrote:
>> Quan Zongliang a écrit :
>>>[...]
>>> Add a new option like "Don't check database version."?
>>>
>> I don't think so. pgAdmin should display the warning box only if they
>> try to backup/restore, and not at startup time.
>
> This is to prevent the user seeing errors when they run an old pgAdmin
> against a newer server - it's not really about backup/restore (the
> thread kinda changed subject).
>
Oops, sorry about this...
--
Guillaume.
http://www.postgresqlfr.org
http://dalibo.com