Re: fsync with sync, and Win32 unlink

Lists: pgsql-hackers-win32
From: Claudio Natoli <claudio(dot)natoli(at)memetrics(dot)com>
To: 'Bruce Momjian' <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: PostgreSQL Win32 port list <pgsql-hackers-win32(at)postgreSQL(dot)org>, 'Tom Lane' <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: fsync with sync, and Win32 unlink
Date: 2004-03-12 07:38:46
Message-ID: A02DEC4D1073D611BAE8525405FCCE2B55F373@harris.memetrics.local
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers-win32


> I have talked to Tom today and he is willing to implement the discussed
> method of doing fsync on every file modified between checkpoints,

Great news.

> and add unlink handling for open files for Win32.

Tom, can you hold off on "unlink handling" part of the implementation, at
least for a few days? I'm testing a patch right now to work around this very
issue (involves, under win32, replacing _open() with CreateFile, which
accepts parameters to allow deletion of the held file. Initial testing looks
good, but it'll need community review).

Cheers,
Claudio

---
Certain disclaimers and policies apply to all email sent from Memetrics.
For the full text of these disclaimers and policies see
<a
href="http://www.memetrics.com/emailpolicy.html">http://www.memetrics.com/em
ailpolicy.html</a>


From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Claudio Natoli <claudio(dot)natoli(at)memetrics(dot)com>
Cc: "'Bruce Momjian'" <pgman(at)candle(dot)pha(dot)pa(dot)us>, PostgreSQL Win32 port list <pgsql-hackers-win32(at)postgreSQL(dot)org>
Subject: Re: fsync with sync, and Win32 unlink
Date: 2004-03-12 14:34:38
Message-ID: 8909.1079102078@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers-win32

Claudio Natoli <claudio(dot)natoli(at)memetrics(dot)com> writes:
> Tom, can you hold off on "unlink handling" part of the implementation, at
> least for a few days?

Love to ;-)

> I'm testing a patch right now to work around this very
> issue (involves, under win32, replacing _open() with CreateFile, which
> accepts parameters to allow deletion of the held file. Initial testing looks
> good, but it'll need community review).

However, I don't see exactly how that can win?

regards, tom lane