| Lists: | pgsql-patches |
|---|
| From: | Gregory Stark <stark(at)enterprisedb(dot)com> |
|---|---|
| To: | pgsql-patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Doc and comment patch for packed varlena |
| Date: | 2007-05-09 17:28:58 |
| Message-ID: | 871whphpnp.fsf@oxford.xeocode.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-patches |
Caught someone using PG_DETOAST_PACKED and VARDATA_ANY on a structure that
required alignment so I guess some more prominent warnings are in order. I
also added a paragraph to the "User-Defined Types" chapter on using these
macros since it seems like they're a hit.
| Attachment | Content-Type | Size |
|---|---|---|
| unaligned-warning.diff | text/x-diff | 6.0 KB |
| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Gregory Stark <stark(at)enterprisedb(dot)com> |
| Cc: | pgsql-patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: Doc and comment patch for packed varlena |
| Date: | 2007-05-15 17:40:00 |
| Message-ID: | 200705151740.l4FHe0o11003@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-patches |
Patch applied. Thanks.
---------------------------------------------------------------------------
Gregory Stark wrote:
>
> Caught someone using PG_DETOAST_PACKED and VARDATA_ANY on a structure that
> required alignment so I guess some more prominent warnings are in order. I
> also added a paragraph to the "User-Defined Types" chapter on using these
> macros since it seems like they're a hit.
>
[ Attachment, skipping... ]
>
>
> --
> Gregory Stark
> EnterpriseDB http://www.enterprisedb.com
>
> ---------------------------(end of broadcast)---------------------------
> TIP 6: explain analyze is your friend
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://www.enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +