Re: [SQL] Function Parameters in GROUP BY clause cause errors

How amazing is that? I call it a night and come back to find that a bug has been identified and patched while I sleep.

When will it appear in the binaries (I see that the release version is still 8.1.3)? I thought about trying to compile from source, but after looking at the mingw page was too intimidated by figuring out what to download to try compiling source.

Best Regards,

Robert Davidson

-----Original Message-----
From: Tom Lane [mailto:tgl(at)sss(dot)pgh(dot)pa(dot)us]
Sent: Wednesday, March 22, 2006 8:27 PM
To: Davidson, Robert
Cc: pgsql-sql(at)postgresql(dot)org; pgsql-bugs(at)postgresql(dot)org
Subject: Re: [SQL] Function Parameters in GROUP BY clause cause errors

I wrote:
> Hmm, this seems like a plpgsql deficiency. It feels it can generate a
> separate parameter symbol ($n) for each occurrence of each variable it
> passes into a SQL query. But for this query to be legal, the two
> instances of IntervalMinutes have to be represented by the *same*
> parameter symbol (notice they are not in the regurgitated query).

> It would be more efficient anyway to not generate multiple parameters
> for the same value, so we oughta fix this.

Patch applied to HEAD and 8.1 branches.

regards, tom lane

On Thu, Mar 23, 2006 at 05:30:28AM -0800, Davidson, Robert wrote:
> How amazing is that? I call it a night and come back to find that a bug has been identified and patched while I sleep.
>
> When will it appear in the binaries (I see that the release version is still 8.1.3)? I thought about trying to compile from source, but after looking at the mingw page was too intimidated by figuring out what to download to try compiling source.

We generally don't worry about point releases too much unless there's a
pretty serious bug, so it'll probably take a while.

Unfortunately I don't know of anyone building nightly binaries. This is
something we should think about doing, especially for windows...
--
Jim C. Nasby, Sr. Engineering Consultant jnasby(at)pervasive(dot)com
Pervasive Software http://pervasive.com work: 512-231-6117
vcard: http://jim.nasby.net/pervasive.vcf cell: 512-569-9461

Jim C. Nasby wrote:

>On Thu, Mar 23, 2006 at 05:30:28AM -0800, Davidson, Robert wrote:
>
>
>>How amazing is that? I call it a night and come back to find that a bug has been identified and patched while I sleep.
>>
>>When will it appear in the binaries (I see that the release version is still 8.1.3)? I thought about trying to compile from source, but after looking at the mingw page was too intimidated by figuring out what to download to try compiling source.
>>
>>
>
>We generally don't worry about point releases too much unless there's a
>pretty serious bug, so it'll probably take a while.
>
>Unfortunately I don't know of anyone building nightly binaries. This is
>something we should think about doing, especially for windows...
>
>

What for? The only binaries we should be letting out are for declared
releases. If the bug is serious enough to warrant cutting a generally
distributed binary for, it's worth making a release for, IMNSHO. The
Windows packaging team usually follow up a release with a package very
quickly indeed.

cheers

andrew

On Fri, Mar 24, 2006 at 09:32:27AM -0500, Andrew Dunstan wrote:
> Jim C. Nasby wrote:
>
> >On Thu, Mar 23, 2006 at 05:30:28AM -0800, Davidson, Robert wrote:
> >
> >
> >>How amazing is that? I call it a night and come back to find that a bug
> >>has been identified and patched while I sleep.
> >>
> >>When will it appear in the binaries (I see that the release version is
> >>still 8.1.3)? I thought about trying to compile from source, but after
> >>looking at the mingw page was too intimidated by figuring out what to
> >>download to try compiling source.
> >>
> >>
> >
> >We generally don't worry about point releases too much unless there's a
> >pretty serious bug, so it'll probably take a while.
> >
> >Unfortunately I don't know of anyone building nightly binaries. This is
> >something we should think about doing, especially for windows...
> >
> >
>
> What for? The only binaries we should be letting out are for declared
> releases. If the bug is serious enough to warrant cutting a generally
> distributed binary for, it's worth making a release for, IMNSHO. The
> Windows packaging team usually follow up a release with a package very
> quickly indeed.

In this case, my guess is that this bugfix isn't important enough to
push a release. If there was a nightly build, the bug reporter could use
that for development until an official release came out.

The only reason I even suggested this is because setting up a windows
build environment is substantially more complicated than building on
unix. If he was on unix, he could easily just cvs up on the appropriate
branch and build it himself.
--
Jim C. Nasby, Sr. Engineering Consultant jnasby(at)pervasive(dot)com
Pervasive Software http://pervasive.com work: 512-231-6117
vcard: http://jim.nasby.net/pervasive.vcf cell: 512-569-9461