| Lists: | pgsql-hackers |
|---|
| From: | Jan Urbański <wulczer(at)wulczer(dot)org> |
|---|---|
| To: | Postgres - Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | compile error with -DOPTIMIZER_DEBUG |
| Date: | 2009-11-22 12:04:12 |
| Message-ID: | 4B0928BC.40704@wulczer.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Hi,
ISTM that there's a superfluous curly brace in print_path (which only
gets compiled with -DOPTIMIZER_DEBUG.
Patch attached.
Jan
| Attachment | Content-Type | Size |
|---|---|---|
| superfluous-paren.patch | text/x-diff | 472 bytes |
| From: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
|---|---|
| To: | Jan Urbański <wulczer(at)wulczer(dot)org> |
| Cc: | Postgres - Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: compile error with -DOPTIMIZER_DEBUG |
| Date: | 2009-11-22 14:55:30 |
| Message-ID: | 4B0950E2.1020500@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Jan Urbański wrote:
> ISTM that there's a superfluous curly brace in print_path (which only
> gets compiled with -DOPTIMIZER_DEBUG.
>
> Patch attached.
Thanks, committed.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
| Cc: | Jan Urbański <wulczer(at)wulczer(dot)org>, Postgres - Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: compile error with -DOPTIMIZER_DEBUG |
| Date: | 2009-11-22 16:41:19 |
| Message-ID: | 7943.1258908079@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> writes:
> Jan Urbaski wrote:
>> ISTM that there's a superfluous curly brace in print_path (which only
>> gets compiled with -DOPTIMIZER_DEBUG.
> Thanks, committed.
You know, the last couple of times I've touched that code, I've been
wondering why we bother to maintain it. Personally I always use pprint()
when I'm interested in a printout of a plan tree. Is anyone actually
using the printout code in allpaths.c?
regards, tom lane
| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, Jan Urbański <wulczer(at)wulczer(dot)org>, Postgres - Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: compile error with -DOPTIMIZER_DEBUG |
| Date: | 2009-11-29 11:33:49 |
| Message-ID: | 200911291133.nATBXn627165@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Tom Lane wrote:
> Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> writes:
> > Jan Urbaski wrote:
> >> ISTM that there's a superfluous curly brace in print_path (which only
> >> gets compiled with -DOPTIMIZER_DEBUG.
>
> > Thanks, committed.
>
> You know, the last couple of times I've touched that code, I've been
> wondering why we bother to maintain it. Personally I always use pprint()
> when I'm interested in a printout of a plan tree. Is anyone actually
> using the printout code in allpaths.c?
I thought OPTIMIZER_DEBUG showed us all the possible paths, not just the
final plan.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, Jan Urbański <wulczer(at)wulczer(dot)org>, Postgres - Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: compile error with -DOPTIMIZER_DEBUG |
| Date: | 2009-11-29 14:35:34 |
| Message-ID: | 14074.1259505334@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Bruce Momjian <bruce(at)momjian(dot)us> writes:
> Tom Lane wrote:
>> You know, the last couple of times I've touched that code, I've been
>> wondering why we bother to maintain it. Personally I always use pprint()
>> when I'm interested in a printout of a plan tree. Is anyone actually
>> using the printout code in allpaths.c?
> I thought OPTIMIZER_DEBUG showed us all the possible paths, not just the
> final plan.
Yeah, but we could repoint that code at pprint.
regards, tom lane
| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, Jan Urbański <wulczer(at)wulczer(dot)org>, Postgres - Hackers <pgsql-hackers(at)postgresql(dot)org>, Tom Raney <raneyt(at)cecs(dot)pdx(dot)edu> |
| Subject: | Re: compile error with -DOPTIMIZER_DEBUG |
| Date: | 2009-12-02 15:02:17 |
| Message-ID: | 20091202150217.GA6276@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Tom Lane wrote:
> Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> writes:
> > Jan Urbański wrote:
> >> ISTM that there's a superfluous curly brace in print_path (which only
> >> gets compiled with -DOPTIMIZER_DEBUG.
>
> > Thanks, committed.
>
> You know, the last couple of times I've touched that code, I've been
> wondering why we bother to maintain it. Personally I always use pprint()
> when I'm interested in a printout of a plan tree. Is anyone actually
> using the printout code in allpaths.c?
Maybe Tom Raney's Visual Planner thing?
--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support